From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15787 invoked from network); 30 Nov 2022 14:57:35 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 Nov 2022 14:57:35 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1669820255; b=pRFAGg+qE4xNzn1V/qXEnQpnuVsjRb7hXABgPQcOv0X3VEgRGpT2SsjFHkvQg/WU8zJJcMe2mp AArzcWoj+HGfugJ739LKVizVLVEYaghmzJ0Ih9oWPRIohuJ3ZLrVo74ikE/8eBvbXcLqma1Kvd IK/RpPFvtYFh2TpI3zcOvgyBulrN1Ec5OQQV+Pe+E3PGzLUacEcsBBwMhwW/KWNq2QLXOajZcB LIKE2qAlLEVcvhX4wuGs/eCoS967RrvGmtHCXZBGE5roYHhcEbkNiD4/mNgkfaC3TlPE9vHGea wbi22XN4PqC9vZhq9GtP5cS78ZXsqPL6dtSCGWKFfhPe8w==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd00011-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.11; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1669820255; bh=oqdjzRczupTWX3F45trOp9IONba8AZcq1OaNuGTtEiE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=TxQFtZv2W3wP3iki97egklW8BFG/X//bML2MwfThpABtNtEnOn5NcPhqyzDaj8ObP+OOVWwhOs fyhIxEmLJ7Hq2HxKwr2ikQwENrRqctCyf/XHLQuazf5sSEY2yDg36ay7U36xsKlgUNvxeOWSWF PU5TpeAFvvD5Op34KeBzrYtDeQGKSpi/9FCAAzhaZfwd1QPgm5MSaAa3zuH0dHUHtJQ2kPnT/H 1LlwRNdVodxSnpQapvoNauRkLZSYnttDRfBzUTY+Djc2ak3WyEuf3vzF4/KNfzH1EVxqfN5hZX BjYtJuw+NrrU9K/e+yOpR0Gkgqdrj6LT81KRU549T0rocg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=MRHeelM5Q1UTEfv5dkzuNWHASCG1U7z6xTewrLiBt44=; b=bDHEO5oNS46tnDhB+cQyi5nxmj 5AkSQmCnrMA+UtwwT1tYuBvxWeFgr2U421Ye1ct22poTZApZUEaDB9tiBtQNkt6w6IXvcSFeYfy65 t+SQfNlbh9x/foyMsFfV/wq6x9lj4TePpMdGa2GF9VXjn1+VZYej1TogSW3avfZ42sGxcygerIG9n g76d3Gbuox4ofUQGoUAQwxxKdK+pXbyNKe0uzqw8z4sw7aQmbZ0Dh44heWZ+P+irXCm1w3Vqs1Kzu QpkNF1N6AGmlMFBxcjqhhW4DEtyBKQQviI1GWzGjhcICmDEht4l8K0QujqxJq5ZFLtMtIWD/khlGl BZrJ8mBA==; Received: by zero.zsh.org with local id 1p0OWk-0001cr-N1; Wed, 30 Nov 2022 14:57:34 +0000 Authentication-Results: zsh.org; iprev=pass (snd00011-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.11; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd00011-bg.im.kddi.ne.jp ([27.86.113.11]:26945 helo=dfmta0004.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1p0OW8-0001Js-KD; Wed, 30 Nov 2022 14:56:58 +0000 Received: from mail.biglobe.ne.jp by omta0004.biglobe.ne.jp with ESMTP id <20221130145650940.DFHZ.63021.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Wed, 30 Nov 2022 23:56:50 +0900 From: "Jun. T" Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [bug] busyloop upon $=var with NULs when $IFS contains both NUL and a byte > 0x7f Date: Wed, 30 Nov 2022 23:56:50 +0900 References: <20221118142717.t4elzrigjeizjm6w@chazelas.org> To: zsh-workers@zsh.org In-Reply-To: <20221118142717.t4elzrigjeizjm6w@chazelas.org> Message-Id: <6581C482-5535-43D6-A784-CF16B5289B80@kba.biglobe.ne.jp> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 51087 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > 2022/11/18 23:27, Stephane Chazelas wrote: >=20 > With +o multibyte, no busy loop, but splitting doesn't work properly: >=20 > $ LC_ALL=3DC zsh +o multibyte -c 'IFS=3D=C3=A9$IFS; printf "<%q>\n" = $=3DIFS' > <$'\303'$'\251'> > <''> It seems this can be fixed by the following patch (use the multibyte code only if MULTIBYTE option is on). The test script above gives <''> <''> <''> <''> I gess this is the expected result (the description of IFS in man zshparam(1) is not easy to understand). If this works OK, then I think we can force reset IFS if an invalid character is found in it when multibyte option is on, because if a user wants (in C locale) to include any byte in IFS then she/he can unset multibyte option. diff --git a/Src/utils.c b/Src/utils.c index edf5d3df7..a182553e7 100644 --- a/Src/utils.c +++ b/Src/utils.c @@ -74,9 +74,6 @@ set_widearray(char *mb_array, Widechar_array wca) } wca->len =3D 0; =20 - if (!isset(MULTIBYTE)) - return; - if (mb_array) { VARARR(wchar_t, tmpwcs, strlen(mb_array)); wchar_t *wcptr =3D tmpwcs; @@ -4118,8 +4115,9 @@ inittyptab(void) * having IIDENT here is a good idea at all, but this code * should disappear into history... */ - for (t0 =3D 0240; t0 !=3D 0400; t0++) - typtab[t0] =3D IALPHA | IALNUM | IIDENT | IUSER | IWORD; + if isset(MULTIBYTE) + for (t0 =3D 0240; t0 !=3D 0400; t0++) + typtab[t0] =3D IALPHA | IALNUM | IIDENT | IUSER | IWORD; #endif /* typtab['.'] |=3D IIDENT; */ /* Allow '.' in variable names - = broken */ typtab['_'] =3D IIDENT | IUSER; @@ -4138,7 +4136,7 @@ inittyptab(void) DEFAULT_IFS_SH : DEFAULT_IFS; *s; s++) { int c =3D STOUC(*s =3D=3D Meta ? *++s ^ 32 : *s); #ifdef MULTIBYTE_SUPPORT - if (!isascii(c)) { + if (isset(MULTIBYTE) && !isascii(c)) { /* see comment for wordchars below */ continue; } @@ -4154,7 +4152,7 @@ inittyptab(void) for (s =3D wordchars ? wordchars : DEFAULT_WORDCHARS; *s; s++) { int c =3D STOUC(*s =3D=3D Meta ? *++s ^ 32 : *s); #ifdef MULTIBYTE_SUPPORT - if (!isascii(c)) { + if (isset(MULTIBYTE) && !isascii(c)) { /* * If we have support for multibyte characters, we don't * handle non-ASCII characters here; instead, we turn @@ -4168,9 +4166,11 @@ inittyptab(void) typtab[c] |=3D IWORD; } #ifdef MULTIBYTE_SUPPORT - set_widearray(wordchars, &wordchars_wide); - set_widearray(ifs ? ifs : EMULATION(EMULATE_KSH|EMULATE_SH) ? - DEFAULT_IFS_SH : DEFAULT_IFS, &ifs_wide); + if (isset(MULTIBYTE)) { + set_widearray(wordchars, &wordchars_wide); + set_widearray(ifs ? ifs : EMULATION(EMULATE_KSH|EMULATE_SH) ? + DEFAULT_IFS_SH : DEFAULT_IFS, &ifs_wide); + } #endif for (s =3D SPECCHARS; *s; s++) typtab[STOUC(*s)] |=3D ISPECIAL;