B02 failure

B02 failure

[Clint Adams]

Same happens with 4.1.

ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
 # The first declare works around the "not an identifier" bug with -h
ZTST_getchunk: read code chunk:
 # The first declare works around the "not an identifier" bug with -h
 declare \! \# \$ * - ? @
 typeset -h +g -m *
 unset -m *
 integer i=9
 float -H f=9
 declare -t scalar
 declare -H -a array
 typeset
 typeset +
ZTST_test: examining line:
>array local array
ZTST_getredir: read redir for '>':
array local array
float local f
integer local i=9
local tagged scalar=''
array local array
float local f
integer local i
local tagged scalar
ZTST_test: examining line:

Running test: Parameter hiding and tagging, printing types and values
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.11048, output: /tmp/zsh.ztst.out.11048, error: /tmp/zsh.ztst.terr.11048
ZTST_test: test produced standard output:

ZTST_test: and standard error:
ZTST_execchunk:typeset:2: not valid in this context: 0
*** /tmp/zsh.ztst.out.11048     Tue Nov 26 08:58:54 2002
--- /tmp/zsh.ztst.tout.11048    Tue Nov 26 08:58:54 2002
***************
*** 1,8 ****
- array local array
- float local f
- integer local i=9
- local tagged scalar=''
- array local array
- float local f
- integer local i
- local tagged scalar
--- 0 ----
Test Test/B02typeset.ztst failed: output differs from expected as shown above for:
 # The first declare works around the "not an identifier" bug with -h
 declare \! \# \$ * - ? @
 typeset -h +g -m *
 unset -m *
 integer i=9
 float -H f=9
 declare -t scalar
 declare -H -a array
 typeset
 typeset +
Error output:
ZTST_execchunk:typeset:2: not valid in this context: 0
Was testing: Parameter hiding and tagging, printing types and values
Test/B02typeset.ztst: test failed.

PATCH: Re: B02 failure

[Peter Stephenson]

Clint Adams wrote:
> Test Test/B02typeset.ztst failed: output differs from expected as shown above
>  for:
>  # The first declare works around the "not an identifier" bug with -h
>  declare \! \# \$ * - ? @
>  typeset -h +g -m *
>  unset -m *
>  integer i=9
>  float -H f=9
>  declare -t scalar
>  declare -H -a array
>  typeset
>  typeset +
> Error output:
> ZTST_execchunk:typeset:2: not valid in this context: 0
> Was testing: Parameter hiding and tagging, printing types and values
> Test/B02typeset.ztst: test failed.

Does this fix it?

Index: Test/B02typeset.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/B02typeset.ztst,v
retrieving revision 1.2
diff -u -r1.2 B02typeset.ztst
--- Test/B02typeset.ztst	5 Jul 2002 10:51:52 -0000	1.2
+++ Test/B02typeset.ztst	26 Nov 2002 14:22:36 -0000
@@ -223,9 +223,9 @@
 >scalar a r y
 
  # The first declare works around the "not an identifier" bug with -h
- declare \! \# \$ * - ? @
- typeset -h +g -m *
- unset -m *
+ declare \! \# \$ \* - \? @
+ typeset -h +g -m \*
+ unset -m \*
  integer i=9
  float -H f=9
  declare -t scalar


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************

Re: PATCH: Re: B02 failure

[Clint Adams]

> Does this fix it?

No.  However, I can remove the ?, @, or both, and get the same error.
Removing any of the others results in a 'not an identifier' error
instead.

> - declare \! \# \$ * - ? @

Re: PATCH: Re: B02 failure

[Peter Stephenson]

Clint Adams wrote:
> > Does this fix it?
> 
> No.  However, I can remove the ?, @, or both, and get the same error.
> Removing any of the others results in a 'not an identifier' error
> instead.
> 
> > - declare \! \# \$ * - ? @

It may have something to do with

2002-09-19  Bart Schaefer  <schaefer@zsh.org>

	* 17692: Src/builtin.c: Prevent typeset of a positional parameter
	before it can do damage, and improve the error message about it.

Probably the test needs rewriting.  I think my change is correct, too,
however, so I'll commit it before anyone else starts fiddling.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************