From: Oliver Kiddle <opk@zsh.org>
To: Zsh workers <zsh-workers@zsh.org>
Subject: PATCH: adjust quoting in (...) action for bpf filters
Date: Tue, 06 Apr 2021 14:11:15 +0200 [thread overview]
Message-ID: <66687-1617711075.655239@GdEZ.q0Yj.Ujfv> (raw)
In 43928, _alternative was brought into line with _arguments in terms of
parsing of (...) actions. That being consistent is sensible but did
change what quoting was necessary. So completion after tcpdump po<tab>
is printing an "(eval):1: parse error" message. I've tried searching for
other potentially affected cases and not found any but it isn't easy to
construct a good regular expression. Note that _regex_arguments uses
_alternative for all the gathered results.
Oliver
diff --git a/Completion/Unix/Type/_bpf_filters b/Completion/Unix/Type/_bpf_filters
index 54e2172c9..b744b1ab4 100644
--- a/Completion/Unix/Type/_bpf_filters
+++ b/Completion/Unix/Type/_bpf_filters
@@ -63,7 +63,7 @@ compquote suf
# protocol or field: it is one, the other or both but not neither
_regex_arguments _bpf /$'[^\0]#\0'/ \( \
- /$'(not[ \0]#|![ \0]#|(\\\\|)\\([ \0]#)'/ ':operators:operator:(not ()' \# \
+ /$'(not[ \0]#|![ \0]#|(\\\\|)\\([ \0]#)'/ ':operators:operator:(not \()' \# \
\(\
\(\
\(\
next reply other threads:[~2021-04-06 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 12:11 Oliver Kiddle [this message]
2021-04-06 15:18 ` Daniel Shahaf
2021-04-10 21:18 ` dana
2021-04-13 11:43 ` Daniel Shahaf
2021-04-13 21:57 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66687-1617711075.655239@GdEZ.q0Yj.Ujfv \
--to=opk@zsh.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).