From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 22106 invoked from network); 6 Apr 2021 12:11:35 -0000
Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368)
  by inbox.vuxu.org with ESMTPUTF8; 6 Apr 2021 12:11:35 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org;
	s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:
	List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID:
	Content-Type:MIME-Version:Subject:To:From:Reply-To:Cc:
	Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From:
	Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References;
	bh=E+3u+Cry3KjSn7/ct715NLgV7KLI6NB8+KF47P5ncfs=; b=aCIE+rmTs/j1wxEDFwMLZz7b2P
	Rkr5WWGhM+deXnlKNpL/dUqwkaxwhL4c+wv4eeooXjZ0iH+nQ3ZrWlgjL1J35YBabbW01zlf05B/4
	YwU1+yAAbLbNSWt2GZzSCSNe0wOp4KB2nCQTLf5T3/y5rwcZQC7f64HdJ3RvbauBVNIbDcw536qsF
	ksK+rHX5+cBpHSekGQmQ7V5bm3gyy0p8QjoNOh3INUnHxPFC8p+nijAtqYMVmHQTBRw1j2AsdRDkg
	3yxsZdk0Sw6hyiifXPdPVLEe4CZy0IYrVS8FU4ABm+TWNxmhnHYwNNPbHDDuTQJ1yXoowBdlC7gzI
	/CVZbZBQ==;
Received: from authenticated user by zero.zsh.org with local 
	id 1lTkYQ-000L2c-3G; Tue, 06 Apr 2021 12:11:34 +0000
Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)
	id 1lTkY8-000Kob-81; Tue, 06 Apr 2021 12:11:16 +0000
Received: from [192.168.178.21] (helo=hydra)
	by mail.kiddle.eu with esmtp(Exim 4.93.0.4)
	(envelope-from <opk@zsh.org>)
	id 1lTkY7-000HLc-LD
	for zsh-workers@zsh.org; Tue, 06 Apr 2021 14:11:15 +0200
From: Oliver Kiddle <opk@zsh.org>
To: Zsh workers <zsh-workers@zsh.org>
Subject: PATCH: adjust quoting in (...) action for bpf filters
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <66686.1617711075.1@hydra>
Date: Tue, 06 Apr 2021 14:11:15 +0200
Message-ID: <66687-1617711075.655239@GdEZ.q0Yj.Ujfv>
X-Seq: 48414
Archived-At: <https://zsh.org/workers/48414>
X-Loop: zsh-workers@zsh.org
Errors-To: zsh-workers-owner@zsh.org
Precedence: list
Precedence: bulk
Sender: zsh-workers-request@zsh.org
X-no-archive: yes
List-Id: <zsh-workers.zsh.org>
List-Help: <mailto:sympa@zsh.org?subject=help>
List-Subscribe: <mailto:sympa@zsh.org?subject=subscribe%20zsh-workers>
List-Unsubscribe: <mailto:sympa@zsh.org?subject=unsubscribe%20zsh-workers>
List-Post: <mailto:zsh-workers@zsh.org>
List-Owner: <mailto:zsh-workers-request@zsh.org>
List-Archive: <http://www.zsh.org/sympa/arc/zsh-workers>

In 43928, _alternative was brought into line with _arguments in terms of
parsing of (...) actions. That being consistent is sensible but did
change what quoting was necessary. So completion after tcpdump po<tab>
is printing an "(eval):1: parse error" message. I've tried searching for
other potentially affected cases and not found any but it isn't easy to
construct a good regular expression. Note that _regex_arguments uses
_alternative for all the gathered results.

Oliver

diff --git a/Completion/Unix/Type/_bpf_filters b/Completion/Unix/Type/_bpf_filters
index 54e2172c9..b744b1ab4 100644
--- a/Completion/Unix/Type/_bpf_filters
+++ b/Completion/Unix/Type/_bpf_filters
@@ -63,7 +63,7 @@ compquote suf
 # protocol or field: it is one, the other or both but not neither
 
 _regex_arguments _bpf /$'[^\0]#\0'/ \( \
-  /$'(not[ \0]#|![ \0]#|(\\\\|)\\([ \0]#)'/ ':operators:operator:(not ()' \# \
+  /$'(not[ \0]#|![ \0]#|(\\\\|)\\([ \0]#)'/ ':operators:operator:(not \()' \# \
   \(\
     \(\
       \(\