From: Kamil Dudka <kdudka@redhat.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: 'cd' built-in crashed zsh on a broken file system
Date: Fri, 23 Jan 2015 14:31:53 +0100 [thread overview]
Message-ID: <6694788.tx155BX634@kdudka.brq.redhat.com> (raw)
In-Reply-To: <20150120203436.4bf346a4@ntlworld.com>
On Tuesday 20 January 2015 20:34:36 Peter Stephenson wrote:
> On Tue, 20 Jan 2015 10:28:10 -0800
>
> Bart Schaefer <schaefer@brasslantern.com> wrote:
> > On Jan 20, 1:35pm, Kamil Dudka wrote:
> > } Subject: 'cd' built-in crashed zsh on a broken file system
> > }
> > } It is not clear to me why pwd was NULL after the return from
> > cd_new_pwd()
> >
> > xsymlink() in utils.c:
> > if (*s != '/')
> >
> > return NULL;
> >
> > called from findpwd() also utils.c, which in turn is only called if you
> > have CHASE_LINKS set.
> >
> > I'm not sure if the right thing to do is test the return of xsymlink()
> > down in findpwd(), or to check the return of findpwd() in cd_new_pwd().
>
> I'd say the latter: dealing with an I'm-sorry-dave-I-can't-do-that is a
> bit neater higher up otherwise the intermediate return values are in
> some sort of limbo.
>
> I don't think there's any point in printing an error message: we don't
> know what happened, so just pretend it didn't.
>
> How about this?
Thanks for the patch! I have applied it on Fedora packages, will let you
know if the problem occurs from now on.
Kamil
next prev parent reply other threads:[~2015-01-23 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 12:35 Kamil Dudka
2015-01-20 18:28 ` Bart Schaefer
2015-01-20 20:34 ` Peter Stephenson
2015-01-20 21:57 ` Bart Schaefer
2015-01-23 13:31 ` Kamil Dudka [this message]
2015-01-24 19:09 ` Mikael Magnusson
2015-01-24 21:56 ` Mikael Magnusson
2015-01-25 3:54 ` Bart Schaefer
2015-01-25 17:54 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6694788.tx155BX634@kdudka.brq.redhat.com \
--to=kdudka@redhat.com \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).