From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 6bee54e7 for ; Tue, 7 Jan 2020 04:17:23 +0000 (UTC) Received: (qmail 9095 invoked by alias); 7 Jan 2020 04:17:18 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45261 Received: (qmail 25763 invoked by uid 1010); 7 Jan 2020 04:17:18 -0000 X-Qmail-Scanner-Diagnostics: from mail-yw1-f65.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25684. spamassassin: 3.4.2. Clear:RC:0(209.85.161.65):SA:0(-1.9/5.0):. Processed in 2.310612 secs); 07 Jan 2020 04:17:18 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.161.65 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5sMsvTOjWsawKI85xsrgh0pn7Ndm2p92t+FDzgzyhOk=; b=fOHuYULFqE5UXwvdZKMhXSkEIHC5AnkXYhspd2hndLLA6qAro09cdcpHtJojJgILmQ O7ynmBfsvReo04P/5d0GwyJEiFhFlNnulMSYi4BZJuP0cxVjr/gsdPBPpPoHLaf3Euya I7k8zI2kynOp4KTtetHzY1j7ifxPxc+Khu667u+uV/9dZv+UvrWNAb/Q0rtV+nj5XYQh LVF2P8i4m36gMz6So/Y8e4c8cepzBoYtZaCcINE4vuWI6rNUEDnC/kG4P2g0EauBbqBk 028FjUSu+UIqMGxLFPfsW1IeDfNnLwxqTZe/1T8F9aY7rRbJiAWbAWUqmv/QEih1BvH8 XYgw== X-Gm-Message-State: APjAAAX4HTrxdfRwEBz+nRXzJv5/yq4kdR7QmUFO5BrzC5n5iyhQAppN lerwdIP5boTlPrwV8ugbZczE+GXR+0n+Kw== X-Google-Smtp-Source: APXvYqxPNJ/mJ06wf4+toYBqDM0JJzhwZMhNm+58iOLeV1pITkq2JLbd+hZLP7ZvpHwhbRh7mCz07g== X-Received: by 2002:a0d:cc4c:: with SMTP id o73mr81072437ywd.482.1578370602941; Mon, 06 Jan 2020 20:16:42 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] _gcc: add some clang specific warnings From: dana In-Reply-To: <20200105185211.11610-1-lists@eitanadler.com> Date: Mon, 6 Jan 2020 22:16:40 -0600 Cc: zsh-workers@zsh.org Content-Transfer-Encoding: quoted-printable Message-Id: <675ADBBB-4F6E-4A7C-8214-7D1E449B4B5E@dana.is> References: <20200105185211.11610-1-lists@eitanadler.com> To: Eitan Adler X-Mailer: Apple Mail (2.3445.104.11) On 5 Jan 2020, at 12:52, Eitan Adler wrote: > This adds some missing completions to the _gcc completer for clang. > Sadly clang does not support --help=3Dwarnings so it is not complete. Merged. It occurred to me that it won't work quite accurately on macOS, though, because gcc is actually clang there. I think this should address it. Or should we go even further and try to = be clever about which options to provide for CFLAGS, &al.? All we could do = with that is guess, i suppose. dana diff --git a/Completion/Unix/Command/_gcc b/Completion/Unix/Command/_gcc index bbfbc2b9e..9ec09200e 100644 --- a/Completion/Unix/Command/_gcc +++ b/Completion/Unix/Command/_gcc @@ -13,6 +13,11 @@ if [[ "$service" =3D -value-* ]]; then args2=3D() fi else + # On some systems (macOS), cc/gcc/g++ are actually clang; treat them = accordingly + [[ $service !=3D clang* ]] && + _pick_variant clang=3Dclang unix --version && + service=3Dclang-$service + args2=3D( '*:input file:_files -g = "*.([cCmisSoak]|cc|cpp|cxx|ii|k[ih])(-.)"' ) fi =20