From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7286 invoked from network); 30 May 2022 16:33:56 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 May 2022 16:33:56 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1653928436; b=BBHwo792JZuzDxK4C9FltwY+KwzI5YGLhcs0RX9FvTbOBlQ2raKRvobog9tDC9eBl9r9P4coF5 UoC4gOBG4JVJSfbFeyHO8fMJcqCymjrFL3VIq2zqy/qxkeOzVdEbxR5TRqtKE0vnAZ3fhf6wyN X61Y2U4YD2JROGbgNStVFLA87IcsLdkMt5v2j9bcpm1Wyxs64vJh6x//26uVxdH2XvVdMksG/f 9lrADm8SyAMi7ffCsuaeh7CLXU/YDbvTnEO52mWNOU5qrDeFzqWOEq1n3jn0m8n8qJdGCTe6bR WICUHtSQjcM4114ZMocX0CfTvgn8pk4E9uh0VnBYoOF88g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd01014-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.30; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1653928436; bh=qhVkZjImyO81zIuzMLWD4rUhFahcKOlMRsplSGFpSE0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=ILrZzXHu85TB7cqERkP/F+xFTGt1UNPyA1X8JrY25MMJlsmqyyOw+deYvDBnfvVRFn8SYsOi9l bVPDnZ+SXvDdBefHGVeV/ICKCKuok/g0ueeZFBCXxD1cZO9ghhKzcTUlaVSPHqL35KftMWyZ2u +KtdjcKkCKGaQFyciM83iRuE7NaQg5JkRPZjgXqZPxxpEClGQifubNg7hu1cM4dRHgOWGaU/ch yQnVmYS6N8ImgRNrb0CI+auQlIoIO1O5PFTIFZ8VhPVgakAwAChpq3GeXj58DmE7lICxUxWzah 3yrHUFhH+YMk+fsHh9/gyhez1rB76y9nZJOwMTNPEbaCng==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=r/HYzHbN7MLinjKk7YaqyYoOxAQw42IiA3rMwFStT1I=; b=bvnKn910OoXhlsXbaYkhF1/qM/ Q9cBvg83097D+K60ARbIjK6WQkwdK79CPMV6IfhnSpGhy/GqUtCojjINXKDqshCYWHx//8ulamdje 7q5MJqCNijuyp4v8hcqMDnLahfQhtLSekt80sDJrq7e3AgFgSV7YQThmqS9G5KXB+hdiXBQr2l7mZ bsv1AS08oSaOLkcxszrXYNeHj/foYGfOyjoJU+q2rWtDT+maaxDtmUeUymjUM359EqV9yb1HkDYOt F0ayt8F/E4zgNkSOabDiqdY2vfkBlAWsbNdAr7t0Vsd4C/yG8JVwbk1VZEPo3LkITvqosxuxt2luq ACew4U1Q==; Received: from authenticated user by zero.zsh.org with local id 1nviL5-0000uS-0U; Mon, 30 May 2022 16:33:55 +0000 Authentication-Results: zsh.org; iprev=pass (snd01014-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.30; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd01014-bg.im.kddi.ne.jp ([27.86.113.30]:29249 helo=dfmta1031.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1nviKU-0000Y5-RA; Mon, 30 May 2022 16:33:21 +0000 Received: from mail.biglobe.ne.jp by omta1031.biglobe.ne.jp with ESMTP id <20220530163311207.PQRO.9121.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Tue, 31 May 2022 01:33:11 +0900 From: "Jun. T" Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: Removing subshell from zargs (see "zargs with -P intermittently failing") Date: Tue, 31 May 2022 01:33:09 +0900 References: To: zsh-workers@zsh.org In-Reply-To: Message-Id: <67D8ACEC-3D46-4EC4-9AAD-C508C7097499@kba.biglobe.ne.jp> X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 50308 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Sorry I missed this post. And I fear I will not be able to going into any detail at least for a few days. > 2022/05/30 5:56, Bart Schaefer wrote: > > However, I also intermittently get this: > > % zargs -n 1 -P 19 -- {1..40} -- f > % jobs > [1] running sleep 60 > [9] + done { "${call[@]}"; } > > Or even this: > > % zargs -n 1 -P 19 -- {1..40} -- f > % > [1] done sleep 60 > % jobs > [9] + done { "${call[@]}"; } (1) On my Mac, it seems that this does not happen if I start zsh by 'zsh -f' (but I don't know why). (2) It seems we don't need the extra background job 'sleep 60 &' to get the problem. (3) I tried the following dirty patch for debugging: diff --git a/Src/jobs.c b/Src/jobs.c index a91ef787f..6e59b5b71 100644 --- a/Src/jobs.c +++ b/Src/jobs.c @@ -2391,7 +2391,8 @@ bin_fg(char *name, char **argv, Options ops, int func) curmaxjob = maxjob; ignorejob = thisjob; } - for (job = 0; job <= curmaxjob; job++, jobptr++) + for (job = 0; job <= curmaxjob; job++, jobptr++) { + zwarn("%d %d", job, jobptr->stat); if (job != ignorejob && jobptr->stat) { if ((!OPT_ISSET(ops,'r') && !OPT_ISSET(ops,'s')) || (OPT_ISSET(ops,'r') && OPT_ISSET(ops,'s')) || @@ -2400,6 +2401,7 @@ bin_fg(char *name, char **argv, Options ops, int func) (OPT_ISSET(ops,'s') && jobptr->stat & STAT_STOPPED)) printjob(jobptr, lng, 2); } + } unqueue_signals(); return 0; } else { /* Must be BIN_WAIT, so wait for all jobs */ When the problem occurs, I get: % zargs -n 1 -P 19 -- {1..40} -- f; jobs zsh: 0 0 zsh: 1 17504 # thisjob = ignorejob zsh: 2 0 zsh: 3 0 zsh: 4 0 zsh: 5 0 zsh: 6 0 zsh: 7 0 zsh: 8 2137 [8] + done { "${call[@]}"; } 2137 = 0x859 = STAT_CHANGED | STAT_DONE | STAT_LOCKED | STAT_INUSE | STAT_NOSTTY maxjob = 8 here, but it should have been decremented to 1? The only place maxjob is decremented is in freejob(), I guess.