zsh-workers
 help / color / mirror / code / Atom feed
* more on the lexing bug
@ 1996-12-22 21:03 Zefram
  1997-01-03 14:01 ` Peter Stephenson
  0 siblings, 1 reply; 2+ messages in thread
From: Zefram @ 1996-12-22 21:03 UTC (permalink / raw)
  To: Z Shell workers mailing list

% \
> ^D
internal:  uncompleted line in history

and the shell exits.

-zefram


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: more on the lexing bug
  1996-12-22 21:03 more on the lexing bug Zefram
@ 1997-01-03 14:01 ` Peter Stephenson
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Stephenson @ 1997-01-03 14:01 UTC (permalink / raw)
  To: Z Shell workers mailing list

Zefram wrote:
> % \
> > ^D
> internal:  uncompleted line in history
> 
> and the shell exits.

What's even worse,

% echo executing command unexpectedly... \
> ^D
internal:  uncompleted line in history
executing command unexpectedly...

Probably ^D shouldn't behave like EOF within zle unless it's the first
character on the first line of input only.  After all, it's expected
to behave like a continuation of the current line, not a new line.  I
think the following patch fixes the behaviour.  It's so simple I can't
help wondering if somebody removed the isfirstln before for some reason?

*** Src/zle_main.c.ctrld	Fri Jan  3 14:33:35 1997
--- Src/zle_main.c	Fri Jan  3 14:33:14 1997
***************
*** 428,434 ****
  
  	    statusline = NULL;
  	    bindk = getkeycmd();
! 	    if (!ll && c == eofchar) {
  		eofsent = 1;
  		break;
  	    }
--- 428,434 ----
  
  	    statusline = NULL;
  	    bindk = getkeycmd();
! 	    if (!ll && isfirstln && c == eofchar) {
  		eofsent = 1;
  		break;
  	    }

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutsches Elektronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1997-01-03 13:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-12-22 21:03 more on the lexing bug Zefram
1997-01-03 14:01 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).