zsh-workers
 help / color / mirror / code / Atom feed
From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Cc: jordanp@gmail.com
Subject: Re: ZSH performance regression in 5.8.1.2-test
Date: Thu, 28 Apr 2022 18:53:45 +0900	[thread overview]
Message-ID: <69FD2736-5C14-4789-8D1D-397121129BEA@kba.biglobe.ne.jp> (raw)
In-Reply-To: <CAHDOzW5iJ2UJ7yKOs08knymPFkT-cursD2_y79KRYkWVepbHLw@mail.gmail.com>


> 2022/04/28 4:54, Jordan Patterson <jordanp@gmail.com> wrote:
> 
>> zsh -xic exit 2>>(wc)
> 
> I get 13007 lines, 1534161 characters.

So your .zshrc (and anything loaded from it) is much smaller than the
tmp.txt I used, but:

>> Can you try the lseek() patch (in my previous post, 50115⁩)?
> Summary
>  'prefix/5.8.1/bin/zsh -i -c exit' ran
>    1.01 ± 0.05 times faster than 'prefix/5.8/bin/zsh -i -c exit'
>    1.13 ± 0.05 times faster than 'prefix/5.8.1.2-test-lseek/bin/zsh -i -c exit'
>   10.27 ± 0.41 times faster than 'prefix/5.8.1.2-test/bin/zsh -i -c exit'

it was about 10 times slower in 5.8.1.2-test (compared with 5.8),
and now with the Bart's lseek patch it is just about 10% slower.
I think 10% is acceptable.

> I needed to add a mode argument to the open in your lseek
> configure check.

Thanks!  I will use the following:
     open(tmpfile, O_CREAT, S_IRUSR)



  reply	other threads:[~2022-04-28  9:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 18:16 Jordan Patterson
2022-04-25 18:56 ` Bart Schaefer
2022-04-25 19:20   ` Stephane Chazelas
2022-04-25 21:27     ` Bart Schaefer
2022-04-26  7:01       ` Bart Schaefer
2022-04-26  8:31         ` Peter Stephenson
2022-04-27  0:33           ` Bart Schaefer
2022-04-27 14:11           ` Stephane Chazelas
2022-04-27 15:02             ` Bart Schaefer
2022-04-27 15:07               ` Peter Stephenson
2022-04-27 15:17                 ` Bart Schaefer
2022-04-26 14:31         ` Jun. T
2022-04-26 15:15           ` Peter Stephenson
2022-04-27  0:55             ` Bart Schaefer
2022-04-27  9:16               ` Jun T
2022-04-27  0:38           ` Bart Schaefer
2022-04-27  9:34             ` Peter Stephenson
2022-04-27 10:28               ` Jun T
2022-04-27 12:42                 ` Jun T
2022-04-27 13:58                 ` Jun T
2022-04-27 15:25                   ` Bart Schaefer
2022-04-27 16:18                     ` Jun. T
2022-04-27 19:54         ` Jordan Patterson
2022-04-28  9:53           ` Jun T [this message]
2022-04-28 14:56             ` Bart Schaefer
2022-04-28 18:51           ` Jun. T
2022-04-29  0:28             ` Bart Schaefer
2022-04-29  2:25               ` Jun. T
2022-04-26  1:08 ` Bart Schaefer
2022-04-26  3:03   ` Jordan Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69FD2736-5C14-4789-8D1D-397121129BEA@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=jordanp@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).