zsh-workers
 help / color / mirror / code / Atom feed
From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: ZSH performance regression in 5.8.1.2-test
Date: Wed, 27 Apr 2022 19:28:18 +0900	[thread overview]
Message-ID: <6AEDDA47-F8ED-4160-8FFF-8D3C70B12490@kba.biglobe.ne.jp> (raw)
In-Reply-To: <632293647.60210.1651052061990@mail2.virginmedia.com>


> 2022/04/27 18:34, Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> 
>> On 27 April 2022 at 01:38 Bart Schaefer <schaefer@brasslantern.com> wrote:
>> 
>> I was pretty sure I'd found a case (on Ubuntu 20.04) where it
>> succeeded on a pipe when there was already data written to the pipe
>> before the seek was attempted.  That was only/exactly for (0,
>> SEEK_CUR).
> 
> A simple test for this still caused the seek on the type to fail
> here, but I could be missing the  key elements.  Should still
> be a safe test with only a few bytes in the pipe, I would think.

OK, I will add this to configure.ac.


> 2022/04/26 23:31, I wrote:
> 
> But at least on my Mac the following seems to work also:
> 
>    if (lseek(SHIN, 0, SEEK_CUR) == 0)

Sorry, it should have been:
    if (lseek(SHIN, 0, SEEK_CUR) != (off_t)_1)

I will modify Bart's patch and post it with the patch for configure.ac.


  reply	other threads:[~2022-04-27 10:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 18:16 Jordan Patterson
2022-04-25 18:56 ` Bart Schaefer
2022-04-25 19:20   ` Stephane Chazelas
2022-04-25 21:27     ` Bart Schaefer
2022-04-26  7:01       ` Bart Schaefer
2022-04-26  8:31         ` Peter Stephenson
2022-04-27  0:33           ` Bart Schaefer
2022-04-27 14:11           ` Stephane Chazelas
2022-04-27 15:02             ` Bart Schaefer
2022-04-27 15:07               ` Peter Stephenson
2022-04-27 15:17                 ` Bart Schaefer
2022-04-26 14:31         ` Jun. T
2022-04-26 15:15           ` Peter Stephenson
2022-04-27  0:55             ` Bart Schaefer
2022-04-27  9:16               ` Jun T
2022-04-27  0:38           ` Bart Schaefer
2022-04-27  9:34             ` Peter Stephenson
2022-04-27 10:28               ` Jun T [this message]
2022-04-27 12:42                 ` Jun T
2022-04-27 13:58                 ` Jun T
2022-04-27 15:25                   ` Bart Schaefer
2022-04-27 16:18                     ` Jun. T
2022-04-27 19:54         ` Jordan Patterson
2022-04-28  9:53           ` Jun T
2022-04-28 14:56             ` Bart Schaefer
2022-04-28 18:51           ` Jun. T
2022-04-29  0:28             ` Bart Schaefer
2022-04-29  2:25               ` Jun. T
2022-04-26  1:08 ` Bart Schaefer
2022-04-26  3:03   ` Jordan Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6AEDDA47-F8ED-4160-8FFF-8D3C70B12490@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).