zsh-workers
 help / color / mirror / code / Atom feed
From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: Weird completion bug in Src/Zle/compmatch.c#bld_line
Date: Mon, 9 Jun 2014 22:25:48 +0900	[thread overview]
Message-ID: <6D8889A3-BCF4-4513-83E8-BAFCFD5F6CF0@kba.biglobe.ne.jp> (raw)
In-Reply-To: <1A1C7709-6FDE-4C00-A366-C6F5C6A4FACA@laposte.net>

What you are getting is not a mystery at all, but may give some hint.

In your patch:

 	    if (!ms)
+                closelog();
 		return 0;	/* Didn't match, give up */

but you need a block { .. } here, as follows:

 	    if (!ms) {
                closelog();
 		return 0;	/* Didn't match, give up */
	    }


If you use your patch, the function returns 0 even if ms is not NULL.
In the original code, the function returns 0 if ms is NULL and llen is 0;
otherwise it returns rl.

I guess your journey continues...


  reply	other threads:[~2014-06-09 13:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <33086926-C7D7-4D33-AF86-4B0D48977555@laposte.net>
     [not found] ` <140607105445.ZM24783@torch.brasslantern.com>
     [not found]   ` <E8AF8725-DB8D-4B77-B914-B9823429614E@laposte.net>
     [not found]     ` <140607123006.ZM25086@torch.brasslantern.com>
     [not found]       ` <35EC1DF1-5D60-42CA-93FB-A6400E4308CF@laposte.net>
     [not found]         ` <140607140205.ZM26027@torch.brasslantern.com>
2014-06-08 10:25           ` Logging/debugging from within Src/Zle/compmatch.c nicolas.canceill
2014-06-08 21:13             ` Bart Schaefer
     [not found]             ` <5902E7DB-F4FD-4486-BE0D-14BAA165FCE9@kba.biglobe.ne.jp>
2014-06-09  9:18               ` Weird completion bug in Src/Zle/compmatch.c#bld_line nicolas.canceill
2014-06-09 13:25                 ` Jun T. [this message]
2014-06-09 13:27                   ` nicolas.canceill
2014-06-09 15:44                 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D8889A3-BCF4-4513-83E8-BAFCFD5F6CF0@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).