From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26960 invoked by alias); 1 Jul 2018 16:17:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43121 Received: (qmail 11239 invoked by uid 1010); 1 Jul 2018 16:17:07 -0000 X-Qmail-Scanner-Diagnostics: from rcpt-expgw.biglobe.ne.jp by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(133.208.98.3):SA:0(-2.6/5.0):. Processed in 1.30157 secs); 01 Jul 2018 16:17:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: takimoto-j@kba.biglobe.ne.jp X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Biglobe-Sender: From: "Jun T." Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] rewrite _killall Date: Mon, 2 Jul 2018 01:17:02 +0900 References: <7EC1FE8D-1B43-4EC2-A787-FC51E5202341@dana.is> To: zsh-workers@zsh.org In-Reply-To: <7EC1FE8D-1B43-4EC2-A787-FC51E5202341@dana.is> Message-Id: <6E41F2AE-E723-4BD5-9507-1FB24AF76C40@kba.biglobe.ne.jp> X-Mailer: Apple Mail (2.3273) X-Biglobe-Spnum: 64031 > 2018/06/28 23:52=E3=80=81dana =E3=81=AE=E3=83=A1=E3=83=BC=E3= =83=AB: > On 28 Jun 2018, at 02:39, Jun T wrote: >> + _arguments -s -S : $args >=20 > `-A '-*'` would be appropriate for this one. I didn't add this because "killall -SIGNAL -" does not complete options if -A '-*' is included. If we do not want to complete options after process names, something like the following (patch to my previous patch) may be necessary. A problem of this is now users can't customize by tag-order. diff --git a/Completion/Unix/Command/_killall = b/Completion/Unix/Command/_killall index a62181c25..d603e6e4a 100644 --- a/Completion/Unix/Command/_killall +++ b/Completion/Unix/Command/_killall @@ -69,9 +69,9 @@ else # bsd and darwin '-t[limit to processes running on specified tty]: :_ttys -od' "-c[with -u or -t, limit to processes matching specified name]: = :_process_names $opts" '-z[do not skip zombies]' - "1: : _alternative 'signals::_signals -p' = 'processes-names::_process_names $opts'" "*: :_process_names $opts" + + '(signal)' -$signals[2,-3] ) - _arguments -s -S : $args + _arguments -s -S -A '-*' : $args =20 fi