* [PATCH] zcurses mouse delay [not found] ` <CAH+w=7agEbfr0JnSpSqf=x-8Ji+edqYXMSbwDEQO6BtaJx6suA@mail.gmail.com> @ 2024-01-14 5:07 ` Bart Schaefer 2024-01-14 5:41 ` Ray Andrews 0 siblings, 1 reply; 2+ messages in thread From: Bart Schaefer @ 2024-01-14 5:07 UTC (permalink / raw) To: Zsh hackers list; +Cc: Ray Andrews [-- Attachment #1: Type: text/plain, Size: 314 bytes --] On Sat, Jan 13, 2024 at 9:03 PM Bart Schaefer <schaefer@brasslantern.com> wrote: > > The test for successful read of a number is wrong, and there's also a > typo in the call to print an error message in the event of an > unrecognized mouse subcommand. Nobody uses zcurses for mouse interaction, I guess. [-- Attachment #2: zcurses-mouse-delay.txt --] [-- Type: text/plain, Size: 758 bytes --] diff --git a/Src/Modules/curses.c b/Src/Modules/curses.c index ad17ed65f..8950cc153 100644 --- a/Src/Modules/curses.c +++ b/Src/Modules/curses.c @@ -1302,7 +1302,7 @@ zccmd_mouse(const char *nam, char **args) zlong delay; if (!*++args || - ((delay = zstrtol(*args, &eptr, 10)), eptr != NULL)) { + ((delay = zstrtol(*args, &eptr, 10)), *eptr != '\0')) { zwarnnam(nam, "mouse delay requires an integer argument"); return 1; } @@ -1326,7 +1326,7 @@ zccmd_mouse(const char *nam, char **args) if (old_mask != zcurses_mouse_mask) zcurses_flags |= ZCF_MOUSE_MASK_CHANGED; } else { - zwarnnam(nam, "unrecognised mouse command: %s", *arg); + zwarnnam(nam, "unrecognised mouse command: %s", arg); return 1; } } ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] zcurses mouse delay 2024-01-14 5:07 ` [PATCH] zcurses mouse delay Bart Schaefer @ 2024-01-14 5:41 ` Ray Andrews 0 siblings, 0 replies; 2+ messages in thread From: Ray Andrews @ 2024-01-14 5:41 UTC (permalink / raw) To: Bart Schaefer, Zsh hackers list On 2024-01-13 21:07, Bart Schaefer wrote: > On Sat, Jan 13, 2024 at 9:03 PM Bart Schaefer <schaefer@brasslantern.com> wrote: >> The test for successful read of a number is wrong, and there's also a >> typo in the call to print an error message in the event of an >> unrecognized mouse subcommand. > Nobody uses zcurses for mouse interaction, I guess. I sure do. My best utilities depend on it. Well ... they depend on zcurses, and adding mouse functionality just seemed like a nice touch. It works fine, I can use the scroll wheel and then ENTER, or click on the element. If my hand is on the mouse anyway I do the latter. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-14 5:41 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <ca1761f1-6d8f-452a-b16d-2bfce9076e25@eastlink.ca> [not found] ` <CAH+w=7ZJsr7hGRvD8f-wUogPcGt0DMOcPyiYMpcwCsbBNkRwuQ@mail.gmail.com> [not found] ` <CAA=-s3zc5a+PA7draaA=FmXtwU9K8RrHbb70HbQN8MhmuXTYrQ@mail.gmail.com> [not found] ` <CAH+w=7bAWOF-v36hdNjaxBB-5rhjsp97mAtyESyR2OcojcEFUQ@mail.gmail.com> [not found] ` <205735b2-11e1-4b5e-baa2-7418753f591f@eastlink.ca> [not found] ` <CAH+w=7Y5_oQL20z7mkMUGSLnsdc9ceJ3=QqdAHVRF9jDZ_hZoQ@mail.gmail.com> [not found] ` <CAA=-s3x4nkLST56mhpWqb9OXUQR8081ew63p+5sEsyw5QmMdpw@mail.gmail.com> [not found] ` <CAH+w=7Yi+M1vthseF3Awp9JJh5KuFoCbFjLa--a22BGJgEJK_g@mail.gmail.com> [not found] ` <CAN=4vMpexntEq=hZcmsiXySy-2ptXMvBKunJ1knDkkS+4sYYLA@mail.gmail.com> [not found] ` <CAH+w=7aT-gbt7PRo=uvPK5=+rR3X-PE7nEssOkh+=fxwdeG_7w@mail.gmail.com> [not found] ` <86efd9d3-c994-4551-ae1b-1358dcc86283@eastlink.ca> [not found] ` <CAH+w=7agEbfr0JnSpSqf=x-8Ji+edqYXMSbwDEQO6BtaJx6suA@mail.gmail.com> 2024-01-14 5:07 ` [PATCH] zcurses mouse delay Bart Schaefer 2024-01-14 5:41 ` Ray Andrews
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).