zsh-workers
 help / color / mirror / code / Atom feed
From: "Rocky Bernstein" <rocky.bernstein@gmail.com>
To: zsh-workers@sunsite.dk
Subject: Re: Weird exit caused in a trap DEBUG which sources a file.
Date: Sun, 3 Aug 2008 07:28:37 -0400	[thread overview]
Message-ID: <6cd6de210808030428odaee1e6ja511305c6dd4ac46@mail.gmail.com> (raw)
In-Reply-To: <20080803114215.219b616a@pws-pc>

Comments in line.

On Sun, Aug 3, 2008 at 6:42 AM, Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
> On Sat, 2 Aug 2008 07:21:43 -0400
> "Rocky Bernstein" <rocky.bernstein@gmail.com> wrote:
>>
>> It may be useful to have some "trap DEBUG" exit codes alter program
>> flow. For example in bash if "trap DEBUG" returns 2, then if you are
>> inside a function that does an immediate return from the function
>> (implementing a gdb "return" command).
>
> This happens on any explicit "return" from a non-function trap.
>
>> It might also be nice to have a "trap DEBUG" exit value which
>> indicates that the next command is skipped rather than executed.
>
> That's a little more tricky:  it's not very clear what the next command
> actually is if it's a complicated expression.  Looking at the code, it's
> not hard to do something here, but making it properly consistent is
> another matter.  I think it would probably work if done at the level of
> commands separated by semicolons, newlines or ampersands (described
> internally as sublists).

I do not see why this is semantically complicated when the trap DEBUG
occurs before the statement it refers to is run.  Can you give a very
specific example of something you feel is tricky?

>
>> And since I brought up "trap DEBUG" execution order again, at the risk
>> of beating a dead horse...
>
> I don't really understand what the issue is.  Is there something about
> the DEBUG_BEFORE_CMD option that makes it hard to ensure it is set at
> the right point (this is not a trick question, that's perfectly
> possible)?

David Korn made a mistake and he says so.  Chet Ramey also says he
changed the behavior because he thought it a mistake too. zsh copied
the mistake. The only claim I've heard for keeping the mistake is
compatibility with previous versions of zsh. However right now there
is no evidence that anyone is making use of this mistake that would
not be happier if it weren't made.  When this mistake was corrected in
bash and ksh, no complaint was registered to keep the old less-helpful
behavior.

Generally one thinks of the default value as the thing most people
would choose. Compatibility is a good thing, but using it as an
argument for keeping a mistake that no one is using, seems to me to be
blindly following a rule without understanding why the rule is there.

So the suggestion is changing the default behavior to something which
follows both bash and ksh of the last 6 or so years.  If nothing else,
both bash and sh emulation in zsh should make this default behavior.

Thanks.


  reply	other threads:[~2008-08-03 11:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  2:38 Rocky Bernstein
2008-07-31  9:01 ` Peter Stephenson
2008-07-31 10:05   ` Rocky Bernstein
2008-08-01 12:29     ` Rocky Bernstein
2008-08-01 13:37       ` Peter Stephenson
2008-08-01 15:21         ` Rocky Bernstein
2008-08-01 15:31           ` Peter Stephenson
2008-08-02 11:21             ` Rocky Bernstein
2008-08-03 10:42               ` Peter Stephenson
2008-08-03 11:28                 ` Rocky Bernstein [this message]
2008-08-03 11:50                   ` Peter Stephenson
2008-08-05 11:18                     ` Rocky Bernstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cd6de210808030428odaee1e6ja511305c6dd4ac46@mail.gmail.com \
    --to=rocky.bernstein@gmail.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).