From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18312 invoked from network); 5 Aug 2008 23:26:52 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 5 Aug 2008 23:26:52 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 81243 invoked from network); 5 Aug 2008 23:26:26 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 5 Aug 2008 23:26:26 -0000 Received: (qmail 16964 invoked by alias); 5 Aug 2008 23:26:09 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25398 Received: (qmail 16937 invoked from network); 5 Aug 2008 23:26:05 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 5 Aug 2008 23:26:05 -0000 Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by bifrost.dotsrc.org (Postfix) with ESMTP id 30A738048ADC for ; Wed, 6 Aug 2008 01:25:59 +0200 (CEST) Received: by wa-out-1112.google.com with SMTP id v27so2153566wah.21 for ; Tue, 05 Aug 2008 16:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=oh4OHJn9lEmLrtPklmSaS9+yeRbUj3HcwMrKGS/eaUg=; b=si9/4LHzMqDo33p788tsSputzvK/wDRXyc4juMKsUu3oBk4PBMd8W7ADh/+doNCrOA /nIHqKeo720urz3hTFkAPOQLs9sDg3NsgGizrLXQjq31Vo3Qx89DWkp0dbcfGGLwjB+7 LLNDw+iYNBMFmELHlURZwg8nsxeTj7js5b5Gk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=C0HEb0cJi5I4BuVJwrYPG/GUIWvOEoeZ6ikaZ9BXRBqz9oH6c5Dyopk7vyMM0VZHKt I47wljQYfQeDPaCTPs4w8tY4J1NZ+0n0InLXIcjgja8ncZEf6brEpCXHM/omqdk5X0jQ /ZoTus1uIhCWKCsyfDn7tIm77xF6jN5Ti5HQw= Received: by 10.114.81.1 with SMTP id e1mr301923wab.11.1217978758684; Tue, 05 Aug 2008 16:25:58 -0700 (PDT) Received: by 10.114.159.2 with HTTP; Tue, 5 Aug 2008 16:25:58 -0700 (PDT) Message-ID: <6cd6de210808051625n3ee7156bw468cbbd1418615c3@mail.gmail.com> Date: Tue, 5 Aug 2008 19:25:58 -0400 From: "Rocky Bernstein" To: zsh-workers@sunsite.dk Subject: Re: trap DEBUG + set -o DEBUG_BEFORE_CMD not setting $? nonzero in current CVS In-Reply-To: <20080805093326.2e2915ec@news01> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <6cd6de210808040308k529da37dh40b8dd1799086420@mail.gmail.com> <20080804184957.421f87c9@news01> <20080805093326.2e2915ec@news01> X-Virus-Scanned: ClamAV 0.92.1/7953/Tue Aug 5 23:41:19 2008 on bifrost X-Virus-Status: Clean I didn't have a problem writing a program that when run gives exit code 0 if this bug is fixed and exit code 10 if not. I tried from checked out sources from a couple days ago when there was a bug versus currently patched sources. It probably shouldn't be too hard to work this into the testing system. #!/usr/local/bin/zsh -f cmd='./fdasfsdafd' [[ -x $cmd ]] && rm $cmd set -o DEBUG_BEFORE_CMD trap '[[ $? -ne 0 ]] && exit 0' DEBUG $cmd # invalid command # Failure exit 10 # Put the above in a file, call it and test the exit code. On Tue, Aug 5, 2008 at 4:33 AM, Peter Stephenson wrote: > Here's a test for the first bug. > > I didn't find one for the second: it's tied to reading commands line by > line from the top-level loop and even running it as a script didn't trigger > it for some reason. > > Index: Test/C03traps.ztst > =================================================================== > RCS file: /cvsroot/zsh/zsh/Test/C03traps.ztst,v > retrieving revision 1.11 > diff -u -r1.11 C03traps.ztst > --- Test/C03traps.ztst 29 May 2007 14:50:29 -0000 1.11 > +++ Test/C03traps.ztst 5 Aug 2008 08:32:02 -0000 > @@ -350,6 +350,44 @@ > >trap > >Working 0 > > + debug-trap-bug1() { > + setopt localtraps > + print "print bug file here" >bug-file > + print "print this is line one > + print this is line two > + print this is line three > + print and this is line fifty-nine." >bug-file2 > + function debug_trap_handler { > + print $functrace[1] > + do_bug > + } > + function do_bug { > + . ./bug-file > + } > + trap 'echo EXIT hit' EXIT > + trap 'debug_trap_handler' DEBUG > + . ./bug-file2 > + } > + debug-trap-bug1 > +0: Relationship between traps and sources > +>debug-trap-bug1:15 > +>bug file here > +>this is line one > +>./bug-file2:1 > +>bug file here > +>this is line two > +>./bug-file2:2 > +>bug file here > +>this is line three > +>./bug-file2:3 > +>bug file here > +>and this is line fifty-nine. > +>./bug-file2:4 > +>bug file here > +>debug-trap-bug1:16 > +>bug file here > +>EXIT hit > + > %clean > > rm -f TRAPEXIT > > > -- > Peter Stephenson Software Engineer > CSR PLC, Churchill House, Cambridge Business Park, Cowley Road > Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070 >