From: "Rocky Bernstein" <rocky.bernstein@gmail.com>
To: "Peter Stephenson" <pws@csr.com>
Cc: "Zsh Hackers' List" <zsh-workers@sunsite.dk>
Subject: Re: preventing the leading space in process substitution
Date: Thu, 11 Sep 2008 11:59:09 -0400 [thread overview]
Message-ID: <6cd6de210809110859n1caa4754o9f5dd0b905e48ae0@mail.gmail.com> (raw)
In-Reply-To: <20080911155416.643a84d3@news01>
[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]
On Thu, Sep 11, 2008 at 10:54 AM, Peter Stephenson <pws@csr.com> wrote:
> On Thu, 11 Sep 2008 07:35:31 -0700
> Bart Schaefer <schaefer@brasslantern.com> wrote:
> > } I can't see why we shouldn't keep the debug-related traps, ZERR and
> > } DEBUG, alive in subshells.
> >
> > I can't think of any reason either, unless maybe there are cases where
> > it could result in the trap being executed in both the subshell and
> > the parent.
>
> Shouldn't normally happen, but I suppose we'll just have to see. I've
> committed the patch.
>
> That's to say, "(echo foo)" causes a DEBUG trap for the (...) itself, and
> then a DEBUG trap for any contents inside the subshell according to the
> normal rules for a list of commands, but I think that's exactly what we
> want (it's the same as for {...}).
Seems to do exactly the right thing. Thanks!
>
> I note that $ZSH_DEBUG_CMD has strange (overlarge) indentation for the
> elements of (...) after the opening parenthesis. I think that needs
> revisiting. I don't quite understand why the default indentation is 1
> instead of 0; obviously that's right for outputting the bodies of
> functions, but the code has many other uses.
>
> --
> Peter Stephenson <pws@csr.com> Software Engineer
> CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
> Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
>
[-- Attachment #2: Type: text/html, Size: 2283 bytes --]
next prev parent reply other threads:[~2008-09-11 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080909144101.GA30693@lapse.rw.madduck.net>
[not found] ` <200809101124.m8ABOlKI005063@news01.csr.com>
[not found] ` <080910074842.ZM19151@torch.brasslantern.com>
[not found] ` <200809101510.m8AFAajX007203@news01.csr.com>
[not found] ` <080910090554.ZM19272@torch.brasslantern.com>
[not found] ` <6cd6de210809101151q4d0a2a35p452fe656e0ee7dd5@mail.gmail.com>
2008-09-11 12:00 ` Peter Stephenson
2008-09-11 12:44 ` Rocky Bernstein
2008-09-11 13:05 ` Peter Stephenson
2008-09-11 14:35 ` Bart Schaefer
2008-09-11 14:54 ` Peter Stephenson
2008-09-11 15:59 ` Rocky Bernstein [this message]
2008-09-11 17:11 ` PATCH: indent in code output (was Re: preventing the leading space ...) Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cd6de210809110859n1caa4754o9f5dd0b905e48ae0@mail.gmail.com \
--to=rocky.bernstein@gmail.com \
--cc=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).