From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: zsh_error_db --- hash-based database of error messages
Date: Fri, 16 Dec 2022 18:05:29 +0000 [thread overview]
Message-ID: <7029e4b9dd41e95b61a8cb3ab78aaf4bc254e3ab.camel@ntlworld.com> (raw)
In-Reply-To: <20221216174605.GE8411@tarpaulin.shahaf.local2>
On Fri, 2022-12-16 at 17:46 +0000, Daniel Shahaf wrote:
> Peter Stephenson wrote on Fri, Dec 16, 2022 at 16:42:53 +0000:
> > Following on from the retread of the discussion on error messages,
> > here's a very simply proof of concept for a hash-based database of
> > error messages. Even if it's adopted I don't intend the C code
> > to get much larger as the point is to allow it to be able to do
> > everything in shell code.
> >
>
> So, tl;dr:
>
> - Every error message would get an E42 identifier in the source string.
>
> - The "E42" will be looked up as a string key in a well-known assoc,
> where the value will be a more elaborate error message.
>
> - The more elaborate message, if there is one, will be used instead of
> the default message.
Yes, that's it in a nutshell; any further complexity would ideally
be in shell code.
I think at least we need something better than E <num> to try to avoid
duplicates, for example E <file-code> <num>. It's easy to search
the file for a duplicate, a bit more of a pain to search the entire
codebase. Maybe a two letter code, so we can have ZW for zle_word.c?
> Code review below.
I think those are all accurate, I'll update for the next version.
pws
next prev parent reply other threads:[~2022-12-16 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 16:42 Peter Stephenson
2022-12-16 17:46 ` Daniel Shahaf
2022-12-16 18:05 ` Peter Stephenson [this message]
2022-12-16 20:05 ` Daniel Shahaf
2022-12-17 21:33 ` Oliver Kiddle
2022-12-19 9:19 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7029e4b9dd41e95b61a8cb3ab78aaf4bc254e3ab.camel@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).