zsh-workers
 help / color / mirror / code / Atom feed
From: Marlon Richert <marlon.richert@gmail.com>
To: Oliver Kiddle <opk@zsh.org>
Cc: zsh-workers@zsh.org
Subject: Re: Bug + patch: _expand() fails to insert unambiguous prefix
Date: Sun, 21 Mar 2021 11:49:42 +0200	[thread overview]
Message-ID: <705461C9-F909-4CF6-97C5-ADB62A9F5A07@gmail.com> (raw)
In-Reply-To: <61690-1616273655.087174@mxKg._JXT.SUbL>

Forgot to CC this to the mailing list. I shouldn’t use email on my phone, apparently.

>>> On 20. Mar 2021, at 22.54, Oliver Kiddle <opk@zsh.org> wrote:
>> 
>> Thanks for your well-thought-out response. I think you have good 
> 
> Whoops! Replying on my phone, I accidentally touched the send button. :/
> 
> Anyway, what I meant to say was, I took your points to heart and spent some time trying to come up with a better solution, only to realize that I cannot find a way to make it work in a good way that takes your points into account _and_ I’m not really that invested in this feature in the first. It just seemed like a nice idea at the time that wouldn’t be too hard to implement. Turns out it has more consequences than I thought about and I don’t really need the feature myself.
> 
> So, long story short: I decided to abandon this patch and go work on something else. If anyone else wants to continue where I left off, feel free to do so.
> 
> Having said that, this exercise have shown me some other areas where _expand could be improved. I’ll submit a new patch for _expand soon (just not for this particular feature).


      reply	other threads:[~2021-03-21  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 19:49 Marlon Richert
2021-03-20  1:50 ` Lawrence Velázquez
2021-03-20 11:20   ` Marlon Richert
2021-03-20 14:42     ` Lawrence Velázquez
2021-03-20 18:22       ` Marlon Richert
2021-03-20 20:54       ` Oliver Kiddle
2021-03-21  9:49         ` Marlon Richert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=705461C9-F909-4CF6-97C5-ADB62A9F5A07@gmail.com \
    --to=marlon.richert@gmail.com \
    --cc=opk@zsh.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).