From: "Thomas Gläßle" <thomas@coldfix.de>
To: Bart Schaefer <schaefer@brasslantern.com>,
Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: Path with spaces in _canonical_paths
Date: Thu, 24 Nov 2022 00:36:09 +0100 [thread overview]
Message-ID: <70f4d652-e824-5594-cdc3-de92d6c6c9b2@coldfix.de> (raw)
In-Reply-To: <CAH+w=7Z9wVCAeJaU+K-wG2jx8LHvUsF9aahUrAPLvMgaLW0STQ@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1104 bytes --]
On 11/23/22 23:42, Bart Schaefer wrote:
> + # ### The following approximates that.
> + matches+=(${(q)${(M)files:#$canpref*}/$canpref/$origpref})
Seems to resolve the issue!
However, there is another weird behaviour that I just now noticed (but
it's unrelated to this patch). When resolving relative paths from within
a symlinked directory, it seems to assume the resolved path of the cwd
as basepath. Maybe best explained by another example:
# ln -s /usr/local/bin /mnt
# ln -s /tmp /foo
# cd /mnt
# compdef '_canonical_paths -N files files /tmp/My\ File' cmd
# cmd <Tab>
../../../foo/My\ File
../../../tmp/My\ File
Notice the amount of ../
> Remains to be seen if it works ... I still can't figure out how to
> cause that code path ("else") to be followed when I try to reproduce
> Thomas's error.
Are you still not able to reproduce, even on the docker? How is that
possible? Can it be different due to terminal? Doesn't really make sense
to me.. Are you able to reproduce @Daniel?
Best, Thomas
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 19183 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-11-23 23:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 17:41 thomas
2022-11-21 3:57 ` Bart Schaefer
2022-11-21 10:47 ` thomas
2022-11-21 16:30 ` Bart Schaefer
2022-11-21 17:41 ` Thomas Gläßle
2022-11-21 21:32 ` Bart Schaefer
2022-11-23 14:13 ` Daniel Shahaf
2022-11-23 21:36 ` Bart Schaefer
2022-11-23 22:24 ` Daniel Shahaf
2022-11-23 22:42 ` Bart Schaefer
2022-11-23 23:06 ` Daniel Shahaf
2022-11-23 23:12 ` Bart Schaefer
2022-11-24 0:12 ` Daniel Shahaf
2022-11-24 18:42 ` Bart Schaefer
2022-11-23 23:36 ` Thomas Gläßle [this message]
2022-11-23 23:40 ` Thomas Gläßle
2022-11-24 18:51 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70f4d652-e824-5594-cdc3-de92d6c6c9b2@coldfix.de \
--to=thomas@coldfix.de \
--cc=d.s@daniel.shahaf.name \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).