From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: Bug in history changes
Date: Fri, 22 Feb 2002 11:19:37 +0000 [thread overview]
Message-ID: <721.1014376777@csr.com> (raw)
In-Reply-To: "Peter Stephenson"'s message of "Thu, 21 Feb 2002 13:07:52 GMT." <8435.1014296872@csr.com>
Peter Stephenson wrote:
> Wayne Davison wrote:
> > On Wed, 20 Feb 2002, Peter Stephenson wrote:
> > > The latest version of the history code is causing zcalc to crash.
> >
> > I'm ashamed to say that my last patch still left a stupid bug in
> > prepnexthistent(). I just committed the following fix to CVS.
>
> I'm still getting the crash after recompiling.
It seems to be the code with HISTEXPIREDUPSFIRST in
putoldhistentryontop() setting the next pointer to something that's
about to be free, but I don't remotely understand the code well enough
to be sure. I made it go away by setting next to NULL if it was
pointing to something that was being freed, but I have no idea if this
is correct, or if that should ever happen.
Whether or not I do that, I now get:
+11:15% unsetopt histexpiredupsfirst
+11:15% HISTSIZE=1
+11:15% h
fc: no such event: 832
This doesn't happen if HISTSIZE is 2 or larger.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 392070
**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
and/or privileged material.
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is
prohibited.
If you received this in error, please contact the sender and
delete the material from any computer.
**********************************************************************
next prev parent reply other threads:[~2002-02-22 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-20 17:00 Peter Stephenson
2002-02-20 19:30 ` Wayne Davison
2002-02-21 13:07 ` Peter Stephenson
2002-02-22 11:19 ` Peter Stephenson [this message]
2002-02-22 11:26 ` Peter Stephenson
2002-02-22 22:00 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=721.1014376777@csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).