From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-44175-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2727b577
	for <ml@inbox.vuxu.org>;
	Mon, 25 Mar 2019 13:08:01 +0000 (UTC)
Received: (qmail 5598 invoked by alias); 25 Mar 2019 13:07:48 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 44175
Received: (qmail 25496 invoked by uid 1010); 25 Mar 2019 13:07:48 -0000
X-Qmail-Scanner-Diagnostics: from rcpt-expgw.biglobe.ne.jp by f.primenet.com.au (envelope-from <takimoto-j@kba.biglobe.ne.jp>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.101.1/25398. spamassassin: 3.4.2.  
 Clear:RC:0(133.208.98.4):SA:0(-2.6/5.0):. 
 Processed in 2.302428 secs); 25 Mar 2019 13:07:48 -0000
X-Envelope-From: takimoto-j@kba.biglobe.ne.jp
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.208.98.4 as permitted sender)
X-Biglobe-Sender: <takimoto-j@kba.biglobe.ne.jp>
From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] Change handrolled strftime to strftime in zftp.c
Date: Mon, 25 Mar 2019 22:07:13 +0900
References: <20190323101135.14344-1-wesley@mintlab.nl>
 <20190323101135.14344-2-wesley@mintlab.nl>
 <CGME20190325121427epcas4p18e794aebecc4f574c6abc701a2080eba@epcas4p1.samsung.com>
 <A7DCA44C-CF98-4A56-8B82-ECAF78337F51@kba.biglobe.ne.jp>
 <1553517734.6561.2.camel@samsung.com>
To: zsh-workers@zsh.org
In-Reply-To: <1553517734.6561.2.camel@samsung.com>
Message-Id: <72612202-4F1F-4B1F-ABAE-1CF730AF1A2F@kba.biglobe.ne.jp>
X-Mailer: Apple Mail (2.3273)
X-Biglobe-Spnum: 7738


> 2019/03/25 21:42, Peter Stephenson <p.stephenson@samsung.com> wrote:
>>  
>> Should we replace "#ifdef OFF_T_IS_64_BIT" by "#ifndef OFF_T_IS_64_BIT"?
> 
> The obvious test would be
> 
> #ifdef ZSH_64_BIT_TYPE

But ZSH_64_BIT_TYPE is defined only if long is 32 bit
so we still get 'Shell compiled with wrong off_t size'.
Do you mean "#ifndef ZSH_64_BIT_TYPE"?