From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_ADSP_ALL, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 8623 invoked from network); 17 Jun 2020 08:43:19 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 17 Jun 2020 08:43:19 -0000 Received: (qmail 10748 invoked by alias); 17 Jun 2020 08:43:13 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 46054 Received: (qmail 10678 invoked by uid 1010); 17 Jun 2020 08:43:13 -0000 X-Qmail-Scanner-Diagnostics: from li1581-109.members.linode.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25842. spamassassin: 3.4.4. Clear:RC:0(139.162.97.109):SA:0(-2.0/5.0):. Processed in 2.212838 secs); 17 Jun 2020 08:43:13 -0000 X-Envelope-From: frederick888@tsundere.moe X-Qmail-Scanner-Mime-Attachments: |signature.asc| X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at tsundere.moe designates 139.162.97.109 as permitted sender) Subject: Re: [PATCH] add missing read-only zfs property "space" To: Daniel Shahaf Cc: zsh-workers@zsh.org References: <20200605081136.82262-1-frederick888@tsundere.moe> <20200617083812.16ac8afc@tarpaulin.shahaf.local2> From: Frederick Zhang Autocrypt: addr=frederick888@tsundere.moe; keydata= mQINBFxIAyABEAC9s9Rutqley+BLPGNyADPo6relqllxSGYC0EhwzsZ4d/nxrJKNlsYmvIG9 xZm2aK+7Otnv/5OPjcK+KYxdN/kYyaGkcZti5Rn/kqzC/axHl3nzaDiTYHLJBdLl8E/Zvvee QPWpSM7Y7jqMDoMSoakxXWG1zaai4F4ZI6JimTlXxAkJYzmUK86fBydc/7bUIL8AD8dm3X5a /HX8G206coB1H/GctJDYxu8GSnNb9RL+YtXbQy58hdbp+5t7YdFrbfgKglzjfB3txMo0iQGE LSIu+Eju+Et50yMcPb/boDTnqPaaGdabomxZrMbz2GpD69iKksEOXrme/hx8+TA7pQZ+8tXU aRG7FBWww8i7va52+tNjJeTootKGd+Q5ulZT8Ye1/n3Gcrpa5vo1nwQQ9f728w20vQg3jYYS /fE5nPetHgxnTPDoOj5yI4ctHe7FykhC41su1OvB2RDVIxx37WD/DdRS2Wn4j2lLB2wlTD1N wAxrjTyLhgYuHi/BGtkrvsyIq90mXztejM6bjihPhONnuzTp6J5ytONF5zuBHhmqZyJsnJmM Uu8WMUHwxCisvKtq4GnMBHb2uC9qb9ZphHTFyVQgUeTLIXPUS88UqXBYhhvEz6MN0yJob/KY 8a6oIL+BxQwUmHvuE4nUQgGF+JJE3aWOyNTHlWN3y9eBbvDrUQARAQABtCtGcmVkZXJpY2sg WmhhbmcgPGZyZWRlcmljazg4OEB0c3VuZGVyZS5tb2U+iQJXBBMBCABBAhsDBQsJCAcCBhUK CQgLAgQWAgMBAh4BAheAAhkBFiEEi/vqW0xEv6zI7F+TH5KL5g2LwR0FAl3knToFCQWHlmMA CgkQH5KL5g2LwR3wxg/+MQKNcbHEgPo8qJOYLdyq0w34Oaxch4TQeFwo1L4/32CkblEQZGo+ +sSYtqHixEc8CuVV2RYYPjCV3/YHnIx/drFJUy87ElRhQtUMixP+OulXRp4HWxOwzsVmFbbV VI6JbiHF1pXRw3WAH/43w51BnLBbd9bTd5TAyUYglQuSGwFaIeSB32k4Yh/6cfntKhGjmY+S mDDtwq4J8uRnfb8NY1BET8gkC1yPIZbp15GL07017vchX50mqbprdbOuECIBxGWwMWgIesJN AwGqng26hEsR8sodGVnznwzbEz63jTJdlp9mYmZ9cdDUvK3FYTinlJheyHKVhHTlTs8oNPuc P21lEnzZjj/G91rxqTKqmpVcIaSHsVlKiuYEJOV0BjCH/H4NVeGXwr8qhu8cTf8D8yUKS4Be 0+H+oWOg3pb1BoIllx4PjT0OrIM1Bu60fF9unsziJOnPcrtwn3IvWBr8ywuM/sOI0k1x6j1L tFGzYUuAWn+xm140o59Y13VR6rsU4+4qSqKlwITOgzMPcbyEcqkR7qdk9RdN+BUwtEVIdL7Y bJrBiyv6maJ1+KkVnBuS2qAUqrnm/2v7zJkDtc0aCDaHNkW9znRTaQER8VhV2ql2jfrwQeBG FtfFt11MeuKHGRJzr7ak458gKBemV6c6SgXPn6D4zawZ8r22GecqM225Ag0EXEgDIAEQAMX1 gALm05E7tbRPI2N9WCTQihGUHmg2NUjK7mx/YJOqyeG2RDrBb7t1kmy1px92qunaF70bo1DM Yz+7kXDJTAIVjxCw4YBBGMpA85LyMivBvkrdv3MxBIAq4dyo+T5Wm43eFR6lRnZGlFg5iDwi hU5T8AMxgqvBntomzSoJpzzdwXRKUwZBwMJySD784RJqPZiyyXQqGKkEUr0g7z0i/84CqOHx Wd6BI2dq+TMfQbZytIgqzhEkOw6JhWgR27RvtkjCqf81NfhmtVDH44+R2yO9D0MkP5KOhoA/ CKfg22TprKlbz2CZ7uhOTt1EiZDNMJKeHV+C2RPs1sX6kgkQr4D0txD9aNGvFQXz0SaCuDe3 WWdfdTKPX6J1lIFajEDGUviB/hn8Dj1cWnVfDsblVBMaPFR+Oqy/eiVVpvekcP6xAD0VG4j+ 3CPhImYDHyR5xZ8LSSp+ELsOKOWnoO1x8Rk2Cl6ZCn/jLwoMYGTz2Wl/y/gWV8kTDxPIHgWX jF28nSs+QuvTU2eX2KbFlPCqDavV/tHT+qSPC7u/JN/zXFAB/YST1zJJfIGrF1NNa4xllfOD nSSnR3GBy/LoLDLQgJaaDvN5jCZ/Et8gKIOSJUJyjuoVf/fQF6EOWeo8Vz5Kkf6VQEMClgZ0 JXCBplo541YIXc4bP5dCRmAlFi4CySP5ABEBAAGJAjwEGAEIACYCGwwWIQSL++pbTES/rMjs X5MfkovmDYvBHQUCXeSdVQUJBYeWYgAKCRAfkovmDYvBHeegD/wJBOAhCJBXstqZl1ybBA4X SLTPxfq46TTl/6wcj8YRAL92Fk65RPFJ8ElE/milfFF8f/9jzTE8NUF5xdkQSZ40JKlGjcNS 0TDV3ESSkEMh3YApDHDkNSmEX//O5SYuSnMD5IgQ+82I6YrsOfHrP7yBf4hF5p6mvXK6bUQB dSnJW5+uLeImXIIIbFzhNekObac6hr/7mE+H0w7/0wB/NdtZhV0kj9aVSxkD45Aqo307NTIl 3bKrUfeyH5qsIy8ivFqsn/mseHtSFhZ7mifEH31vALFkmsRfmbZyKFzZ8LmOyyEi7gCWVGiw fUM5+OjQ1OeRxfPlea3emLoxKW4JGcPQO9KoJrpLWSWfkGkGGWGv1PM0SXE17uDFNUbS1qm9 hyMfwK3zuV9pQURWJoL7DxIrdhePoCgMAbR3x3a40Ih6ECXleD+OVR6cAvaq3n0eM0CANg0O u3GHboGWF5/BboHxaYbTPWO3bHUedZEseGGABnysYA2mUYWopdeoRxYF2OolmEQoMGnUS5yt C77oHQqkjt2OTDy23UEvFm1m8qG0NK9i2/g6Wpwzf3XXNMbVVXqS/QfBLMhPT3cCA+TEycZU 7K6QQ+7C/wkLGiW70zOGH2WPIjsBntff06yjQOzajGgo4nqMCs9cKxSdvIrf+2vMPtghj/uY A1v6kuz5uWCQObkCDQRcmzksARAAprK42aBVDD6tVWMpxxt+0/Vt5msH2yo+ptp7YvNyPskI H13GhEJR4AzPbYXLFDI/uXu5DcKhtMs63u4Xg1BlInNFm1jA74og+lHe8ZqQbqh8Et5VHSl1 hqIyqEDvODRfHaik5AE8l9qwkHA6CwTgGGUwcZbO2ixJhWYXqLGJjMXFwz9oYQHOhx7zZvpz +FkarvR/gMuJqRMo1jss4afIsT/CI1cVm2XJ76flujrjei6ti80C9V4jmmFPpLQ85n0Y8Uit G89+JpObCNgTM8Vi9/RaVSjyenhpbOhdj7A3dyG9Ggqaid3v1sMbRR+NZmUFJumfJBVsoMTV OEJoA0zWKFELxM0d3Ba7YgjrIYCXtL94b4Y+2bp47HvB5POw8h1V+b8mT2BZEJwuf0hm4DIN wIP6x4PiTRfL05gai21FIhunoqjbP69IIsfGjNj98bw2kyDkdtG5j38HEcQAxNgOtZjespIt pmRMEvUHdNOOEWl5Nx0y7y4R091gRIddVzYQlfqGNjabTX63VAo0zF9c04K2KSGJLQ9fMuKr A83iFE3yhRYjifGY3jJwZ8HXBWfQa83udI+sJL/hR/C520KYxNu6GYuL9ejJ6+W9NiGTyq2n NIwfohkl+slxDBOIuR930r1QEm4gNVSTCzYjXyyUXyGwyEWHXKRPmMLzgMR4RC8AEQEAAYkE cgQYAQgAJgIbAhYhBIv76ltMRL+syOxfkx+Si+YNi8EdBQJd5J1VBQkFNGBWAkDBdCAEGQEI AB0WIQSbpCPYQagDqsdJpgRXyYTgX/cqowUCXJs5LAAKCRBXyYTgX/cqo+caD/9F1sAQdVFs k+bh4JSNjtpQ+BKjuJ9ZIozqP0De6ViNUeBMV5LTkDf7CoaKJNBx6OCGO9WCmWVMTtJPMpj8 3QZNDfGI4vm0saGS0YMopv6eMmo84K+9gm+HiEUXTHydllI/6CGwVUNccQ0PVNswcS6rqq4J ib5oM5GRwL0V5lXbo3UTy5fCmFkQdldKdBO7cXGeuG0/9ImoMCMaAgqrqJlcH0FDyevPehG5 aqAdWFaEo8fiIVjv5rM0v9tBuo972W7iWpEK74C8gf5ZYTdMrmTB52KxLd9rXkdkqgXMbquC VpNYCu66PHRhC0XhRrU95/PGyQprG2WMG0JqwBhtL/PZtwMNW3fSxyUqsqvTblYbam/j9Wyr TqZcjYkHKJTY2LEuKAMlqALwsNKJbRmxwa+uyGkBie2pheJ9g8SsxkiA9jg/72Jlag1WQWBS h6RPIVUo7RvtjK2/gWoT3x2hcA9yyIRod9CPGpjo9yB21g4mRyaLKH8UIQW5Zhrz49rNmtPp 6pzOqleNFf7m/s2fIp4hOHf+NH+VBFuKtfkjzbT5YS0vSww6UVV6HvWORjzAbVR7g1p7vrrD 5ynu4o4Vb8R62dioyjYVOa1SGTqXBBIXNWhN+8uOZXIp+zxt0GmNbt8mQjeMphYCT0Yur4a+ TcBmg+UkC7nOY9sH/X1MvSWQmAkQH5KL5g2LwR371xAArTUzexPwlYYZekF7/Es4EC21y5bq geSnFXgUQ8wTAq4yuDVCyWi1l0d1qMrW6vNqV6t4PGulvsOordMdwPzTo/qkXFcAhgjF2N/+ L4Q53UZWKPIJuHIe4vi6cGyg0jmTVIP29Q60Pj82gTlKGBxXr1BKquoxahK0Zwsz7YM2PqFY 1TzqqzDZl6roisQRhbCD0To4c6nsdNdYCr0KapFNBXhVPCd2XH+uJOeywQHJsABLmo7QJjHY YLZKm0Q+12BNGQN++u4o/gqjRYMESCecVGIqDqecRethdwKUkhcPE3RI4iZ5xe5oNL7yyLgK gCYUzcIUSxPidB8MOXfaaSmputr3xLqsssU++xlbTib7sZU0yiczTt3VSg5X4gTNz+SnJdCa eZ/9oCdsZEhVPgIyRR1gj6TAqFMswi3fBx8bqwq55Yl4LjBPjTVt/i0Kad/g+JtJoqhlz86z iBQK7oF6BHpEtzMDlM9fDslQf4NmLVtzwyY492ZI/5hRtY2N7GXFWWclCflQvtVCxRZgZIhn BS2BRpaXEo/Vocj+nq40GXWkqJfl9PWwrJWn0g9y4PSLfveSpb8mUDnfXs7hyUQj4u1sg5LP YxE5AnmTp+l5KIJ3euM0hnt0kIaT0ebko1driv7jj6rB1hi4U6h/FmADvNbR0jH3THScklC4 lzXZeVQ= Message-ID: <7273c994-fe23-f67b-94e4-7ca0e56bda1b@tsundere.moe> Date: Wed, 17 Jun 2020 18:42:24 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200617083812.16ac8afc@tarpaulin.shahaf.local2> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vEBUse270spUJR2Qux4Vz7tEji8PJx0KH" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (smtp.tsundere.moe [0.0.0.0]); Wed, 17 Jun 2020 08:42:34 +0000 (UTC) X-Virus-Scanned: clamav-milter 0.102.3 at Fred-Linode X-Virus-Status: Clean --vEBUse270spUJR2Qux4Vz7tEji8PJx0KH Content-Type: multipart/mixed; boundary="rilUpDMdzcNkrBHC5YarXz4CznEuAbsyw" --rilUpDMdzcNkrBHC5YarXz4CznEuAbsyw Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable It's documented in the man page under Subcommands -> zfs list: > -o property > (omitted) > =E2=80=A2 The value space to display space usage properties on fil= e systems and volumes. This is a shortcut for specifying -o name,avail,u= sed,usedsnap,usedds,usedrefreserv,usedchild -t filesystem,volume syntax. On 17/6/20 6:38 pm, Daniel Shahaf wrote: > Thanks for the patch. >=20 > I see that =C2=ABzfs list -o space=C2=BB works, but I don't see any ref= erence to > the value =C2=ABspace=C2=BB in the help output (`zfs list -o foobar 2>&= 1`) or man > page. Is that value supported and undocumented? Or is it undocumented= > because it's deprecated? >=20 > workers@, could someone take over the review, please? I have a few > patches to finish and don't want to spread myself too thin. >=20 > Cheers, >=20 > Daniel >=20 >=20 > Frederick Zhang wrote on Fri, 05 Jun 2020 18:11 +1000: >> Signed-off-by: Frederick Zhang >> --- >> Completion/Unix/Command/_zfs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Although it's only documented under 'zfs list', it seems to be availab= le >> to other subcommands as well, e.g. 'zfs get'. >> >> diff --git a/Completion/Unix/Command/_zfs b/Completion/Unix/Command/_z= fs >> index 814358bc7..452e1160d 100644 >> --- a/Completion/Unix/Command/_zfs >> +++ b/Completion/Unix/Command/_zfs >> @@ -132,9 +132,9 @@ _zfs() { >> ) >> =20 >> # TODO: userused@ and groupused@ could have more extensive handling >> ro_properties=3D( >> - "name" "type" "creation" "used" "available" "referenced" >> + "name" "type" "creation" "space" "used" "available" "referenced" >> "compressratio" "mounted" "origin" "usedbychildren" >> "usedbydataset" "usedbyrefreservation" "usedbysnapshots" >> "defer_destroy" "userused@" "userrefs" "groupused@" >> "keychangedate" "keystatus" "rekeydate" >=20 --=20 Best regards, Frederick Zhang Email: frederick888@tsundere.moe PGP: 8BFB EA5B 4C44 BFAC C8EC 5F93 1F92 8BE6 0D8B C11D --rilUpDMdzcNkrBHC5YarXz4CznEuAbsyw-- --vEBUse270spUJR2Qux4Vz7tEji8PJx0KH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEm6Qj2EGoA6rHSaYEV8mE4F/3KqMFAl7p13EACgkQV8mE4F/3 KqNV9hAAluT8bl3cEO5YfTpQDhRA8OhBb/znJb7fco+j9oa6B9L/df+rgmjSIFJ0 3KfE6l41kcymJg/WyPplVoY+FsIxqOppXFmm9P4r87xjL9XOH1I+GC9mUgtjhUjZ DKWDwSCbNB6Yt8+flpnGCtM9WVBI8tNEFb+zxA0tpcPhIGn7O7/q4dl1LrEvij6b vJJnn6qppCQsjo06mvd7DvFjlrxoHRntGe2tfM+epKKy+ryoxvLcuALt3S5eok+8 4tDQYwaOF+S0kyGdEkEiRCRXoXL6ie35B9lcFraaPDGlLdV1c2o+ipqx+8OM8e0Q AlzLmgIL7aLCDsxhnS2TgeV0C0S/I9mwDDw0NeClBwf1x2YrJMstD9i2xT9NotVe oyfldyYqNIuSsvQd/sXo+jvmo+fsM7Ze/R/jpvGYwpzV0HfRS79VvsFbP1EnPlsg 5IuJB2UILoocETp2jkm/wfCPGzfgleCw+quQIBu0JtsCJxzGbIaBzk8/wRiAangk qiPkAfTfZH4Tb8BBTS6E0XwMv0hdj7TVqvcApxKXvVaE/dHNibUpoCq60wZhGY03 PllelKUDfnomyViREUIis1svFtdbRVxO+kyoOeqzVIj7AtD5PPxbxdcAC9ahuWP7 SN9stWZAmZGI/zKWXHSuPhNxCRW/9AG+N8zIOkWAZKGmUozr9Lk= =nmty -----END PGP SIGNATURE----- --vEBUse270spUJR2Qux4Vz7tEji8PJx0KH--