zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: ZTST_continue (was Re: Lots of test failures when --disable-multibyte)
Date: Wed, 6 Apr 2022 14:37:06 +0100 (BST)	[thread overview]
Message-ID: <728406102.562615.1649252226266@mail2.virginmedia.com> (raw)
In-Reply-To: <42130AB1-3B57-4127-9550-1CF2FF0D5857@kba.biglobe.ne.jp>

> On 06 April 2022 at 06:32 Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
> > 2022/04/06 5:29, Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> > 
> > This might help?
> 
> I've been preparing basically the same patch. The only differences are:
> use (( $ZTST_continue )) so that "ZTST_continue=0 make check" will work,
> rename "failures" --> "ZTST_failures" to avoid possible (future) conflicts.

You might as well go ahead.
 
> With the patch below:
> (1) if a chunk in %prep fails then the test is aborted immediately.
> (2) If the "bad placement of 'test' section" happens, we do not exit immediately
> but run ZTST_cleanup.
> Or should we run ZTST_cleanup even in (1)? (it will do no harm...)

Well, since it shouldn't happen it's hard to know what to do if it does.
Cleaning up anything that did get added in the preparation would be kind
of logical, so I can't see why not.

pws


  reply	other threads:[~2022-04-06 13:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04  2:03 Lots of test failures when --disable-multibyte Bart Schaefer
2022-04-04 14:43 ` Peter Stephenson
2022-04-04 15:31   ` Bart Schaefer
2022-04-04 16:23     ` Peter Stephenson
2022-04-04 21:10     ` Bart Schaefer
2022-04-04 21:45       ` Bart Schaefer
2022-04-04 22:00         ` Bart Schaefer
2022-04-05 16:00           ` Bart Schaefer
2022-04-05 16:15             ` Mikael Magnusson
2022-04-05 20:29           ` Peter Stephenson
2022-04-06  3:48             ` Bart Schaefer
2022-04-06  5:32             ` ZTST_continue (was Re: Lots of test failures when --disable-multibyte) Jun T
2022-04-06 13:37               ` Peter Stephenson [this message]
2022-04-07 12:33                 ` Jun T
2022-04-07 12:34                 ` Jun T
2022-04-04 18:52 ` Lots of test failures when --disable-multibyte Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=728406102.562615.1649252226266@mail2.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).