zsh-workers
 help / color / mirror / code / Atom feed
From: "Lawrence Velázquez" <larryv@zsh.org>
To: "Julian Prein" <druckdev@protonmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] cd: Append 2nd argument to CWD if 1st is empty
Date: Fri, 01 Dec 2023 13:21:34 -0500	[thread overview]
Message-ID: <72dcfda2-9b2b-4c76-8e53-ee3332553edc@app.fastmail.com> (raw)
In-Reply-To: <3uINOrbo4IXmuxTPyOMY6U_gv4-qULOThBv5Hd01KcO76FK9AvEFOOIo02fy5VQBIrudqP7rz__wEo1FOG2X2cMLkJzV1wp-1fYkCKYID_8=@protonmail.com>

On Fri, Dec 1, 2023, at 8:32 AM, Julian Prein wrote:
> My motivation to submit this patch was primarily the assumption that specifying
> an empty argument is an edge case that is not well defined in the documentation
> and that the current behaviour is limited in its use cases. To me an appendix
> seems more flexible in the ways a user can utilize this.

FWIW the current behavior -- while undocumented -- is aligned with
that of ksh, and this change would break that alignment and become
one more thing for ksh emulation to handle.

	% cd /bin
	% ksh -c 'print "$KSH_VERSION"; cd "" /usr'
	Version AJM 93u+ 2012-08-01
	/usr/bin
	% mksh -c 'print "$KSH_VERSION"; cd "" /usr'
	@(#)MIRBSD KSH R59 2020/10/31
	/usr/bin

The old behavior is not a bug, and the new behavior doesn't strike
me as particularly useful, so it's not clear to me that this would
be worth it (either as a breaking change or one hidden behind yet
another option).

-- 
vq


  parent reply	other threads:[~2023-12-01 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01  3:11 Julian Prein
2023-12-01  9:21 ` Roman Perepelitsa
2023-12-01 13:32   ` Julian Prein
2023-12-01 13:51     ` Mikael Magnusson
2023-12-01 15:05       ` Julian Prein
2023-12-01 18:21     ` Lawrence Velázquez [this message]
2023-12-01 18:27       ` Roman Perepelitsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72dcfda2-9b2b-4c76-8e53-ee3332553edc@app.fastmail.com \
    --to=larryv@zsh.org \
    --cc=druckdev@protonmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).