From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2541 invoked from network); 27 Apr 2022 15:08:05 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 27 Apr 2022 15:08:05 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1651072085; b=h7wFj8FvW2FvnNsNRK312XGEDoH9TYzenORZJWQcY1dXWuscDpJXecFhxhJeu+cztlMl8Wc8oF OVnHAAWhqZeTsBxVk8U/qLDFS7MUHZssMVH/TEGUuMFth6nySdEmVY1RfwNlrGEZ/oWv83DpKT 7MO9XGLUieCryka1amfO/s9I3k3uFoBT40CY158P8S0hqTrAfmLKsKlP/DL79aIEfosuS60IJe 8Hl1R6iYwyOzViA7JWuUmukZVvQeGY0NWwAz6uLgHs2RZhmBErJrE3jRXpL8t4U+C4p5mY0+3q iLT+hcJvR1LjFugosApcVFhi1dGUcn8laPJbEC8g4g3t2w==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (smtpq2.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.97; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1651072085; bh=ISzia9xV7WeLCCtLJc/tzOFU/teTr/J/Vv6W9JT6518=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=siyRhybohTiIQWg8MFWAQDBQDGhh+GddWY1Xi2lgqL/JbdRjjI9P4smozWVYr1Ep6uoLEvSGg9 +AMVxYcSp34cnYmc5ETwBjOzjtLxAvl/pvzvghsyOlIPBbwMblxyyRsWF9Wy01ZBuxC5QwJvX/ TFfe0bMNh/4F//fzPVkdQ0jph1JpEPXnyh0pE7wgGdVu3TPdKG+IV0VehDGSoocD62qTG1t/C9 KhnfifQhdGPcg1zjy+/y2x6mx6ywztkmSkAaBmXeNICkI9/oXUew7VbjYMcvSrF/XyRt15zaik 9vh6TAKfJq0LbPziS95+4qsCvIMqwse+Jr3bJimwoJFvOA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=5YJn7iE2D2Bf9dgJxRLKAVtcsIFg4cgM5dOZrPd4KNA=; b=DeLwAGZ1sbk3U9wbWsJgWEe+KH dr5P39GtArW/EIG/EVbTkk8rgecLJJpcfvXLaQ4nqpspZ9/bZAPdm//IU899/v/JL+JaqG0OzzIfW 5yLaTcH18R98VaNb+pgvPjJNIneehckVnCp3GGVWJgwh8+qX2FTw3OgiXZiS1ji4Ipm6BSJQGGrAt cfUcMIcH4xUbPiaWymqnqPodGVYLIUpxKSErlslAGPR7BizxiQRnvV6ePJLEVm6JL/w9/YyHC1yvK 0yXfwlSwrdxn8KukiOhF8BGnr/AGSGyMF0VcTzVhMLAQ8WBPo/JftPAW6VMn5nF9TSfKKBMaovo3N drvMuR9g==; Received: from authenticated user by zero.zsh.org with local id 1njjGv-000Hbz-If; Wed, 27 Apr 2022 15:08:05 +0000 Authentication-Results: zsh.org; iprev=pass (smtpq2.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.97; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from smtpq2.tb.ukmail.iss.as9143.net ([212.54.57.97]:55112) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1njjGb-000HGr-SL; Wed, 27 Apr 2022 15:07:46 +0000 Received: from [212.54.57.81] (helo=smtp2.tb.ukmail.iss.as9143.net) by smtpq2.tb.ukmail.iss.as9143.net with esmtp (Exim 4.90_1) (envelope-from ) id 1njjGb-0002CG-Ne for zsh-workers@zsh.org; Wed, 27 Apr 2022 17:07:45 +0200 Received: from oxbe3.tb.ukmail.iss.as9143.net ([172.25.160.134]) by smtp2.tb.ukmail.iss.as9143.net with ESMTP id jjGbnfH8Pv24mjjGbnoBBO; Wed, 27 Apr 2022 17:07:45 +0200 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.134 X-CNFS-Analysis: v=2.4 cv=LKR1/ba9 c=1 sm=1 tr=0 ts=62695c41 cx=a_exe a=rX2mKgs1IZJU9lF6pltyEQ==:117 a=I_Av47A-8eYA:10 a=IkcTkHD0fZMA:10 a=vinPr5In5y8A:10 a=q2GGsy2AAAAA:8 a=N898d1J4AAAA:8 a=NEAV23lmAAAA:8 a=Lw2O5fe_lrOsfAGP8KYA:9 a=QEXdDO2ut3YA:10 a=z9dJwno5l634igLiVhy-:22 a=4OhKILdWXy8MGewZJRtY:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1651072065; bh=ISzia9xV7WeLCCtLJc/tzOFU/teTr/J/Vv6W9JT6518=; h=Date:From:To:In-Reply-To:References:Subject; b=MlkORb3u66i6UqrbWgPjXMLd22BNtIH5tSn3QZEqQkhfr17aTYwNsszz8lZj6te9e hrUgWUgSrMhmCigLXNpwcyBCtsJUztL1PmMNhKrQd0atyPvrdYx0aXB7lsDG2wVlAn wRM8bnQKgEDDELvVeTUyOm+p+HEcR5P7wvNObNtbg0g4aST6M1tBR/y7XNBMkfKpuB f/IZrkiWvWshYECzmD5Stdo7ieDKydV5L9KcAXNDUX9q2EHagQOtBADMOWaVQqBTmF oxfJu972mzD33y9Z9PYiOanVjQifFoWGqxpoI1Rfj0SYeTHbsptvLB5nQmIWWZE0mc pbGUmwQhMa+Rw== Date: Wed, 27 Apr 2022 16:07:45 +0100 (BST) From: Peter Stephenson To: Zsh hackers list Message-ID: <732728967.75854.1651072065633@mail2.virginmedia.com> In-Reply-To: References: <20220425192036.p6awbyro2a2lp7bq@chazelas.org> <1592299421.100566.1650961915601@mail2.virginmedia.com> <20220427141117.6cn4ca72kexv622s@chazelas.org> Subject: Re: ZSH performance regression in 5.8.1.2-test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev72 X-Originating-IP: 165.225.17.146 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfIGklR9U+3yNyEOnyxZ9W1V3jMU+/RBtWHIamt8rLl/QwgJBIUdWeB6zQ5fZXmYP7cijaU7WBOtJU48z9b8PWUAsJV3GvPvad3dE5SrB51NzDbOB/oZt maAZbi8ZyqRxdTX3fyutv8bYM+/5QbKmNYEVh2m+XFtx7a+Ml34gbd8437/yn/4OVZRkq1cQuZj0GJLgqLIi6tS9U+YsWurVCox4HUpSeSe/TW0/B4VigBcI X-Seq: 50119 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > On 27 April 2022 at 16:02 Bart Schaefer wrote: > On Wed, Apr 27, 2022 at 7:12 AM Stephane Chazelas wrote: > > > > 2022-04-26 09:31:55 +0100, Peter Stephenson: > > [...] > > > Not sure how much difference it makes but to avoid additional system calls > > > we could cache the result, invalidating it when we open a new file. > > > > FYI, see https://github.com/att/ast/issues/15 for the kind of > > issue you can find with ksh93 caching read data. > > I think the idea was to cache the result of the "can we lseek" test, > not the data that was read. Yes, I wouldn't expect that to change until we reopen the channel, which is detectable locally within input.c as we need to set up the pointers at the same time. pws