From: Wayne Davison <wayned@users.sourceforge.net>
To: zsh-workers@zsh.org
Subject: Re: Improving some return-value checking
Date: Wed, 16 Dec 2009 10:53:18 -0800 [thread overview]
Message-ID: <733654e30912161053v3eeddb8n2fed6f31fe7f8599@mail.gmail.com> (raw)
In-Reply-To: <20090315005826.GC18440@blorf.net>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On Sat, Mar 14, 2009 at 4:58 PM, Wayne Davison <wayned@users.sourceforge.net
> wrote:
> The second is specific to checking the return value of pipe() [...]
> I haven't yet patched the various read()/write()/fwrite() calls
> that are not checking their return values
>
I finally got back to this, and checked in some cleanup for both the pipe()
calls and the read()/write() calls that were causing compiler warnings.
This gets rid of all the "ignoring return value" compiler warnings, and
should make some of the read/write calls slightly safer (since they now
handle EINTR). There is one remaining FIXME (in exec.c) where I didn't
error-handle an mpipe() call. Since it wasn't error-handled before, it will
be fine for now, but we may want to figure out how to do an error exit from
that point.
..wayne..
prev parent reply other threads:[~2009-12-16 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 0:58 Wayne Davison
2009-12-16 18:53 ` Wayne Davison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=733654e30912161053v3eeddb8n2fed6f31fe7f8599@mail.gmail.com \
--to=wayned@users.sourceforge.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).