zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG] Issue with set built-in in 5.8 (?)
Date: Tue, 18 Feb 2020 14:01:34 -0600	[thread overview]
Message-ID: <75380C1D-ED7C-46A8-AB57-5FC9892581A5@dana.is> (raw)
In-Reply-To: <20200217090236.17a82c53@tarpaulin.shahaf.local2>

On 17 Feb 2020, at 03:02, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> - Compatibility with what zshoptions(1) has promised would work, though
>   that didn't work before 5.8.

zshoptions(1) doesn't say anything about set aborting the shell, AFAIK. Only
zshbuiltins(1) does (under setopt, strangely), and it only states that a 'bad
option name' does it — nothing about any implicit errors that might occur when
changing a valid option.

On 17 Feb 2020, at 03:02, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> - Consistency with POSIX.  (POSIX doesn't specify -p, but still.)
> - Consistency with other shells.

I can't even find where in POSIX it says that set should abort the shell. dash
and ksh93 do work that way, but bash and yash don't.

On 17 Feb 2020, at 03:02, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> - Regardless of what we choose, the other behaviour is achievable: if
>   we make the error fatal people can use «eval» to make it non-fatal,
>   and if we make the error non-fatal people can use «… || exit 1» to
>   make it fatal.

Of the two, the latter seems more intuitive

dana


  reply	other threads:[~2020-02-18 20:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17  2:19 dana
2020-02-17  9:02 ` Daniel Shahaf
2020-02-18 20:01   ` dana [this message]
2020-02-19  9:37     ` Peter Stephenson
2020-02-19 19:25       ` dana
2020-02-20  9:30         ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75380C1D-ED7C-46A8-AB57-5FC9892581A5@dana.is \
    --to=dana@dana.is \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).