From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43758-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d45e656f for ; Sun, 4 Nov 2018 00:13:29 +0000 (UTC) Received: (qmail 15406 invoked by alias); 4 Nov 2018 00:13:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43758 Received: (qmail 10209 invoked by uid 1010); 4 Nov 2018 00:13:12 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f172.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.166.172):SA:0(-1.9/5.0):. Processed in 3.528082 secs); 04 Nov 2018 00:13:12 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=r81KESnsiyVVbIUy3lXCEl3QK+4S93Akitb26wX8tPg=; b=f5YmW5teP2th/iPzX+omR+MR0vpu//nIpVNsUJ/t3Va5j3i9Y5d+G88hyaG6xa6kbZ 647BKaDt3KwdHJCEERoEcgLb6YPLV25+IODMcoNi+uMRSZgkkSHy8HRKOXAk66k9UbX7 o6+IKwj7gm5ibDTzB3si8cWagRecByV2Q1tFgPfpGEqBiSb3IXgKpYa4aVJYTkepbz90 hNfeAtp0lpgO4Svtn7cvjt3OKiHG0sDCnlS2Ky7n5VuZEfleSK0SQxiVy42JwABVaQl7 mXotxhKUZ8Y/n+FtuJYCmhMYW44q/6EWgtYvPbBSiHUC3cKyrghqhqpSKLoHXPH868qA GDsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=r81KESnsiyVVbIUy3lXCEl3QK+4S93Akitb26wX8tPg=; b=TlNcgFFFBWxBlhIf8z5gimIon2Nzsp7O2vE3wX8EF37GNzceCf+BBzAhDGCtEyOwX/ IMVqWTzUPNa686Teu+g0u11+Kd7fFfZQCfB68mFUolN6S5ekJ3ZKZONF+3VpzCezdqvV 2bQ1zUdqepbx7KAKetPoxInf+dvD5spR0jM+bLLlXmCwqk6Bn07NApA3iMImre/gOcCT 03ZgGoVD/kDAcw/t9Lhofc+q/V8Csyg9sdRMqTt0Mx3QqgJZ7JsXwiEmitp4/Hkw9/2q itNqJk2pxrlviWfO+dGVnFa35GNqECAyF+bBOj8icMEz7dwPyZwmSOGSHcYCPVy4YLbv lixA== X-Gm-Message-State: AGRZ1gJxpgs/W9w6Qik3b718uq3aj4JLs3/4oKcS3amWTWPzYdYrIKe+ v9/dUG2pkRUeBpfCg3uq+qlPR5vJ8McYAw== X-Google-Smtp-Source: AJdET5elnN8O4YF4Pk8wjNzLi+/ovIy2xMmEmpSXCOqgaDBSVUD0y0vyhs0rKpa0EWDAI3QRwwnssA== X-Received: by 2002:a24:9645:: with SMTP id z66-v6mr2297642itd.176.1541290384921; Sat, 03 Nov 2018 17:13:04 -0700 (PDT) From: dana Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [PATCH] Completion: Sort lz4 compression levels properly (+ a question) Message-Id: <75B26F45-E6E6-44BB-80A4-7301CBE480FE@dana.is> Date: Sat, 3 Nov 2018 19:13:03 -0500 To: Zsh workers X-Mailer: Apple Mail (2.3445.100.39) This isn't super necessary but it irritated me. Is there a better way to do this? Off the top of my head i came up with = either this state method or calling compadd from the argument spec... but both = of those involve an awful lot of boiler-plate just to keep some numbers sorted. If there's no generic way to do it, would it make sense to have some = kind of spec modifier that tells action forms like `(item ...)` that -V should = be used, or, if that's too weird, a helper function (_presorted maybe) that just = wraps compadd? dana diff --git a/Completion/Unix/Command/_lz4 b/Completion/Unix/Command/_lz4 index d69091d00..4d2721bd5 100644 --- a/Completion/Unix/Command/_lz4 +++ b/Completion/Unix/Command/_lz4 @@ -42,8 +42,8 @@ args=3D( '(b t -k --keep)--rm[remove source file]' '!(b t -c --stdout)--to-stdout' + b # Benchmark-mode options - "(C c d t)-b-[benchmark file using specified compression = level]::compression level:(${(j< >)levels//-/})" - "(C c d t)-e-[specify upper compression level limit (with = -b)]:compression level:(${(j< >)levels//-/})" + '(C c d t)-b-[benchmark file using specified compression level]:: = :->levels' + '(C c d t)-e-[specify upper compression level limit (with -b)]: = :->levels' '(C c d t)-i-[specifiy minimum evaluation time (with -b)]:evaluation = time (seconds)' + c # Compress-mode options "(b d t ${(j< >)levels} -c0 -c1 -c2 -hc)"${^levels} @@ -98,6 +98,11 @@ case $state in _message 'no more arguments' && ret=3D0 fi ;; + levels) + _wanted -2V levels expl 'compression level' \ + compadd - ${(@on)levels//-/} \ + && ret=3D0 + ;; esac =20 return ret