From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9719 invoked from network); 1 May 2023 11:40:22 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 May 2023 11:40:22 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1682941222; b=lw63Ja3Fr2CW5sPf6hk5Trvd+hqeB0LheodZNzRJeA++Vhz4q0yCQr0vHe3HOwtp2pmvvrzT6L jKgmn7PcU4Xv3j+4Pln1kRwQWm5VNKVzrAeeOf65fqwpUy63AddiiKKKL8EocJpvUBdCjLCWGq mPbQZwNltgV0PBZFHpw96T5RZD6RhzE3K/UTNOJq49MS6HIxx3p6kpTNlbhfPpmbnFm8oyT2vZ fJ4sR3Fww1T0DLxB0wbOxjx4IDYGn1foLCX/t24TB4NPuoH19IXgA/gmkFDpdWaGWDi22O0h6m 3JlNmAvqS3LgNgaxS0F7Cde3LPrUEDaBRYg7/lNgkpcDFg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd01013-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.29; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1682941222; bh=DgbGDQduP+V1sG9m9BVb/06wQP4tmiarphFUEvFYpTs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:To:Date:Message-ID:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=BfFFYK9bt3qicWdvHBYNEUQ7X61EAnJ0MekMYicpWPBf3bNV3lyccHIxugToxserDrr8uEc3TN VZ7toOaJOkgcdiQOysDJr6nf2ecyezcRREZ1H5W2FHFmiPJYSpJbbegr4MrDKaN110Wa+03cc7 nnU+Gvf/R5SS1hUYByKzij9O3TmqEQPQYLB2KeZQReyqHIIzkYyBfCwqBaylsq/6srHk8ze5ax UwUw8HDK6mvUQA4Q1reyqvCOnNJaWfQEtkDYWY/JQ3O85kV+JAfMAfBDHaw4QPWupqs9HOQ9GU HZ+zOz5jsjTdznSbP3v92d/fylxeG16QkVrudF9f0c0prA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:To:Date:Message-Id:Subject: Mime-Version:Content-Transfer-Encoding:Content-Type:From:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References; bh=d2WuZXFDHQ5RmVeCJ9I4oVGBxjhVoDoYCtMFc+iu27E=; b=JwdxmwKwV29PXSAtlVzSShUbZj 9GEijlebNLw1fgB9vWpfSfN9dgjYXoVXhYBzg0jI6nrsJB0n07uv8c6TOBGNCG1jGK4a0oHlQb5rU wnKNkCQrxmNUqJxPY2WXzrbogjZrU74xKVj/j7ZjN+nZRD30OOh78piFhE0+1mgJbD0vpfFx0gp6d /Fr0DhYWUnzdkbj36FYEA0suv8DmqQ5lg9X4HWpU+VL13wVpDJUsE3uoqQQNTWhwmpWt0fuxKNKzY RX/dZfROu2o8Hk5MydXcXG01iDMLnWdTvSHCPJtZzSg6UmoIOwkBjR9LyjGqgfYR/JVYYS8SkpD47 ++WFEl9g==; Received: by zero.zsh.org with local id 1ptRtB-0005RC-Lb; Mon, 01 May 2023 11:40:17 +0000 Authentication-Results: zsh.org; iprev=pass (snd01013-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.29; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd01013-bg.im.kddi.ne.jp ([27.86.113.29]:61601 helo=dfmta1021.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1ptRsZ-000588-KC; Mon, 01 May 2023 11:39:43 +0000 Received: from mail.biglobe.ne.jp by omta1021.biglobe.ne.jp with ESMTP id <20230501113932985.OSRS.38622.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Mon, 1 May 2023 20:39:32 +0900 From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: [PATCH] do not skip tests for [[ -r file ]] and [[ -N file ]] on Cygwin Message-Id: <7683CD71-EA4F-49DC-91CD-B393584615EB@kba.biglobe.ne.jp> Date: Mon, 1 May 2023 20:39:31 +0900 To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.3445.104.21) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 51692 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Currently two test cases in C02cond.ztst are skipped on Cygwin: [[ -r file ]] skipped by commit baa1145609 (by Peter), Nov. 2008 [[ -N file ]] skipped by commit 475ba659a2, May 2001 It seems these need not be skipped anymore. If you have Cygwin please confirm that test C02 passes with the patch below. # -r/-N will not work on FAT32 (USB stick?), but then many other tests # would also fail. I think we can assume NTFS for our purpose. diff --git a/Test/C02cond.ztst b/Test/C02cond.ztst index 4366b4142..daea5b4f8 100644 --- a/Test/C02cond.ztst +++ b/Test/C02cond.ztst @@ -111,10 +111,6 @@ if (( EUID =3D=3D 0 )); then print -u$ZTST_fd 'Warning: Not testing [[ ! -r file ]] (root reads = anything)' [[ -r zerolength && -r unmodish ]] - elif [[ $OSTYPE =3D cygwin ]]; then - print -u$ZTST_fd 'Warning: Not testing [[ ! -r file ]] - (all files created by user may be readable)' - [[ -r zerolength ]] else [[ -r zerolength && ! -r unmodish ]] fi @@ -148,9 +144,7 @@ =20 print -ru $ZTST_fd 'This test may take two seconds...' touch $newnewnew - if [[ $OSTYPE =3D=3D "cygwin" ]]; then - ZTST_skip=3D"[[ -N file ]] not supported on Cygwin" - elif (( isnfs )); then + if (( isnfs )); then ZTST_skip=3D"[[ -N file ]] not supported with NFS" elif ! zmodload -F zsh/stat b:zstat 2> /dev/null; then ZTST_skip=3D'[[ -N file ]] not tested; zsh/stat not available'