zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: Bug: Searching through sufficiently large $historywords causes seg fault
Date: Tue, 09 May 2023 20:01:36 +0100	[thread overview]
Message-ID: <76e1d7d098d80e2c8bb9746ba964a0fbd41cc140.camel@ntlworld.com> (raw)
In-Reply-To: <CAH+w=7bgzq=kwg9N5+0_RHo=OmjL82NQxoNnXyhdSh9AKEBynQ@mail.gmail.com>

On Tue, 2023-05-09 at 09:58 -0700, Bart Schaefer wrote:
> On Tue, May 9, 2023 at 9:53 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
> > With 51722, $#historywords is incorrect (returns "51" where it should
> > be about 100,000) and I eventually get a segfault after scrolling back
> > through the history past the event that was added with "print -S'.
> 
> Scratch that ... I had not correctly recompiled.  After correctly
> recompiling, I can't reproduce the segmentation fault at all with
> 51722, but the event added with "print -S" is entirely missing from
> $historywords even though it is found when scrolling the history.

That sounds fine --- it's the division into words, not the line, that's
causing the problems which this avoids.

In this case it's presumably the original word counting, not the
re-spliting on reading a history file, that's causing the underlying
bad numbers.

pws




  reply	other threads:[~2023-05-09 19:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08  8:58 Marlon Richert
2023-05-08 17:01 ` Bart Schaefer
2023-05-09 16:53   ` Bart Schaefer
2023-05-09 16:58     ` Bart Schaefer
2023-05-09 19:01       ` Peter Stephenson [this message]
2023-05-09 23:05         ` Bart Schaefer
2023-05-10  8:39           ` Peter Stephenson
2023-05-12  9:28             ` Peter Stephenson
2023-05-12 16:12               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76e1d7d098d80e2c8bb9746ba964a0fbd41cc140.camel@ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).