zsh-workers
 help / color / mirror / code / Atom feed
From: Filip Krska <fkrska@redhat.com>
To: zsh-workers@zsh.org
Subject: Re: zsh syntax check fails on correct if [[ usage (rhbz 966911)
Date: Wed, 20 Nov 2013 09:08:05 -0500 (EST)	[thread overview]
Message-ID: <77656324.60392877.1384956485213.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20131019225602.38f2cf01@pws-pc.ntlworld.com>

Many thanks, Peter,

we've tested both commits

http://sourceforge.net/p/zsh/code/ci/9a044f1a6ad4ecfdfeff2f89e1685a1d622cb029/
http://sourceforge.net/p/zsh/code/ci/8879c46a4897a0e347455334fc6b6732c203a220/

and the issue seems solved after the patches were applied.

Best Regards

Filip

----- Original Message -----
From: "Peter Stephenson" <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Sent: Saturday, October 19, 2013 11:56:02 PM
Subject: Re: zsh syntax check fails on correct if [[ usage (rhbz 966911)

On Sat, 19 Oct 2013 14:19:58 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> The only oddity that persists is that "zsh -fvc 'something'" does not
> display any verbose output for 'something'.

This affects verbosity of execution of strings for fc editing, sched,
STTY and inside zregexparse, too, but it's not clear that's wrong, and
they're all non-standard cases where we get to choose.

diff --git a/Src/exec.c b/Src/exec.c
index e95cad3..d5fe69e 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -1027,6 +1027,11 @@ execstring(char *s, int dont_change_job, int exiting, char *context)
     Eprog prog;
 
     pushheap();
+    if (isset(VERBOSE)) {
+	zputs(s, stderr);
+	fputc('\n', stderr);
+	fflush(stderr);
+    }
     if ((prog = parse_string(s, 0)))
 	execode(prog, dont_change_job, exiting, context);
     popheap();

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


  reply	other threads:[~2013-11-20 14:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18 14:02 Filip Krska
2013-10-18 15:33 ` Peter Stephenson
2013-10-18 19:12   ` Peter Stephenson
2013-10-18 15:48 ` Bart Schaefer
2013-10-18 15:56   ` Peter Stephenson
2013-10-18 19:20     ` Bart Schaefer
2013-10-18 22:43       ` Peter Stephenson
2013-10-19 21:19         ` Bart Schaefer
2013-10-19 21:46           ` Bart Schaefer
2013-10-19 21:56           ` Peter Stephenson
2013-11-20 14:08             ` Filip Krska [this message]
2013-10-18 19:29   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77656324.60392877.1384956485213.JavaMail.root@redhat.com \
    --to=fkrska@redhat.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).