From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,MALFORMED_FREEMAIL, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id c132b153 for ; Thu, 27 Jun 2019 23:02:12 +0000 (UTC) Received: (qmail 4910 invoked by alias); 27 Jun 2019 23:02:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44461 Received: (qmail 4163 invoked by uid 1010); 27 Jun 2019 23:02:07 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25489. spamassassin: 3.4.2. Clear:RC:0(205.235.26.22):SA:0(-0.3/5.0):. Processed in 0.659082 secs); 27 Jun 2019 23:02:07 -0000 X-Envelope-From: SRS0=Poq/=U2=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at bounces.park01.gkg.net designates 205.235.26.22 as permitted sender) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1561676489; bh=R9YUTKblw/J+A+hLWLJPDKJ5JTo8+VDkEDV7n9DLwB8=; h=From:References:To:Subject:Date:From:Subject; b=o4OHfdGDBrBM0Z52SJt5z4fwtv1E1d6hVOetw9qxzXcA8NKVGr3zBgLBWs/Cn9/TIij0emuo3R562mxrMnXmZbEHjNeQ0du9uUUm6IyEYxdtY3wC1PX8sXKnnV3wFNoKNMVCVLK6QUwHx6PWhOgHiHjm0rAhcuPZaGGZW9ko0oHEDyAvFGZ1UqSmi0h5l0bLUXwAtPQJnp69AqloFeSNReOKInA9r6JxzcueRu123Bop4yGKyWv5o+bd5SCyNT++4dhFXBfXONT7uzIrxUzQitXOK7Nz3eCgbgC4xpXafdFDVPDaYs0TREGMKomxaaKeNdntWkG7kt4I2Rev5qVrBQ== X-YMail-OSG: KL_ImPYVM1lLxvLYUfpELopeBbAbPpMjpuhCwSDs9bYaSxHGJAyVsjruzKZzX4l lmWgOIB8cUrUs5_6K4KLFovNgxUjSFIL5g0oescw4SXOboLjacZlEGXkCxOxGkaIbrs2P.edtgp3 kr7qPyos8.h6ihskLbwyDudrawqQmu1eXAg.ntSvIYfQY9KbEcaHn5hfUASX4Hi1KwQXA9evtr6z 7yS3wYmBj4s9ilcVE5phbJoJIVqRY0ohXQnxOz_qUH8udJ6Gp5V60i0ZL8IQdG4kOrxLVwRqx7cU Nzjw0k2vMsf4rptKmoWK2pnwojs3rZxw0.KFtoGOmAl5mZ5.w1zd1CW7KZFROuetOXgCqlyTDLk4 O7JDrQCnSoSLuDu6BXxZ1igdG9URc5qE7l5fbxmTwjewyeXbeb.ZeuF.IdzJG.rpsdqNG3wWsXHR KRc7Vx40rzB7_RBhddILZJDePkqmC85BmFbNigHfRDmNPcT59Y.5R9a.54uOpsS72W7GS14eJz6y JXmc5QfRlS.11VmBWlXlg2th1JnWe7IsoEXNi1ZMUSVda79Z7TuCGzSEtS_Wd6AGZxkkk5FZtNZA qWCP57dkQ0DDqYWZy_5SgqmDuRqpjRqt6443oSneYNNMU8rMFay5I5et5a7NINH2hCtpx7Djnb0B n97_R5Z_e41TYhHVVkLQRQ_VQmx8CLOpcoHMhBsik_WzWBX9DkwRz3geMp7GkmnyKokQ6UWVEdEM MqTRVJ4lJ9kLQ3Cy90Z8NyWFlb88SK6n9uaREyE5Aw642T5PGa1lxwMFf_HJs5qbVUgEnFYmAPPr dOkBCccgGLjlwyDWOLC98CqEiNGapf_X1gTClvAIIthCfaRlP22cn.V8OY3uTFw68C9BPs9epvjQ 3JAY3l44yrlknWrcEIP97_Hb7z8HJO.hbchdQLdgwOuh4QzVE02aF1hzZIvkTxuisD9FyA9nkUkL wmCuId8r.3k55.SWIHOX5BTsbbZ.3IEXiteaUx61dd70PC4qWaGuNs7a6TuuE4ObY3olzUUgAvb3 f570xS8lnFvCm381jS3lXYMcBj3N3p4vJ7a9nB6VNwtdg8PZhMkChWPmdok9cFSzatElkM6.XSfa M_aAFaj4LdZKY1J3e1rBhlU.sRPEVC5Mhe79l7Tf2IUTJaXuQaTX2p65K17TrTMLzmxfe0_2BoAd GU8DMeMJ2HIQzHUYgFQEYlm1.gezenK_yeO9ljQ-- cc: zsh-workers@zsh.org In-reply-to: <20190626101908.548-1-kdudka@redhat.com> From: Oliver Kiddle References: <20190626101908.548-1-kdudka@redhat.com> To: Kamil Dudka Subject: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <796.1561676485.1@hydra> Date: Fri, 28 Jun 2019 01:01:25 +0200 Message-ID: <797-1561676485.902916@C-Cf.WCnE.5Cn6> Kamil Dudka wrote: > There is a bug report in Red Hat Bugzilla about zsh crashing on NULL > pointer dereference: https://bugzilla.redhat.com/1722703 > > I was not able to reproduce the crash myself but the attached patch > should prevent zsh from crashing in this situation. It'd perhaps be good to add a DPUTS call here because while it is good not to crash the condition does perhaps indicate a bug and it'd be better not to hide it completely. I can't reproduce the crash either but there must be some plugins or url quoting magic going on here. More details of the setup used by the user might help find the underlying problem. Oliver