Bug report: complist miscalculates width of display strings containing a slash (/)

Bug report: complist miscalculates width of display strings containing a slash (/)

[Marlon Richert]

The following test causes the command line to jump and the completion
menu to visually break when the terminal is 80 columns wide. Similar
effects can be achieved for other terminal sizes by adjusting the
length of the file names. In addition, thereafter, there are
additional redraw errors in the completion menu when changing the
selection. In particular, compare how the menu is redrawn when moving
the selection horizontally vs. vertically. All of this appears to
happen only for file completions of which the display string contains
a slash (/).

$ cd $(mktemp -d); ZDOTDIR=$PWD HOME=$PWD PS1='%# ' exec zsh -f
% zmodload zsh/complist
% autoload compinit; compinit
% mkdir {1..9}foobarba
% _tst() { local -a files=( ~/* ); local -a displ=( "${(@D)files}" );
compadd -d displ -P '~/' -fW ~/ - $files[@]:t }
% compdef _tst tst
% bindkey '^I' menu-select
% tst \t\t

Re: Bug report: complist miscalculates width of display strings containing a slash (/)

[Jun. T]

> 2021/03/27 7:49, Marlon Richert <marlon.richert@gmail.com> wrote:
> 
> The following test causes the command line to jump and the completion
> menu to visually break ...

Thank you for reporting, and sorry for not responding quickly.

It seems the problem occurs if both '-d disp' and '-f' are given to
compadd, and menu-select is called.
# It becomes more serious if width of the list of completions
# is equal (or close?) to the screen width due to the wrapping.

The following patch add an extra width 1 for the trailing file-type
indicator (/ for directory, etc.) when '-d disp' is given, just as for
the case without '-d disp' (line 2351, 15 lines below the patched line).



diff --git a/Src/Zle/compresult.c b/Src/Zle/compresult.c
index 30fc60b78..8b5955819 100644
--- a/Src/Zle/compresult.c
+++ b/Src/Zle/compresult.c
@@ -1583,7 +1583,7 @@ calclist(int showall)
                             nlines += 1 + printfmt(m->disp, 0, 0, 0);
                             g->flags |= CGF_HASDL;
                         } else {
-                            l = ZMB_nicewidth(m->disp);
+                            l = ZMB_nicewidth(m->disp) + !!m->modec;
                             ndisp++;
                             if (l > glong)
                                 glong = l;