From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: (qmail 19650 invoked from network); 15 Mar 2020 01:05:30 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from unknown (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTP; 15 Mar 2020 01:05:30 -0000 Received: (qmail 20099 invoked by alias); 15 Mar 2020 01:05:17 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45559 Received: (qmail 5946 invoked by uid 1010); 15 Mar 2020 01:05:17 -0000 X-Qmail-Scanner-Diagnostics: from mail-qk1-f194.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25744. spamassassin: 3.4.2. Clear:RC:0(209.85.222.194):SA:0(-1.9/5.0):. Processed in 3.150096 secs); 15 Mar 2020 01:05:17 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.222.194 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fVfkwNOIk/mKnIcoKXBeNS1+uclQLfJPMbBVz9KSGAs=; b=ig8xRVi4yvi+WYl4MIJK86CPj3v3iART7QPdnqEbH4xyu05cY5gh6PjS2mxpkh9e1q j6Zzsq5dvl0JzkiiY7AblVGb4yBAq70J8DSFT25UGQ5FmwLYXawq7fpPp/xGOatQkTCk WvqwVNJgs2Q5Vtt455s74K3eJKFLVymfbZiR7SwwF1WXvehn0hXmjQw/7jW2M0TlB0Wi U4aF3fEMsr4GUPrwHKWEay99nIivWVdWaIYC8llzVvajbOx+xaZ1sd3GKZTont0GWMhv +Ri0kC1xTwe49lIdZdbtLASAbkjMFXr4pYDEWMi4cRC6awhyAhi8FSHofx40U8cSV5kZ Gtqg== X-Gm-Message-State: ANhLgQ2F0ZbOYRq26olNOPU+5XBMN9W+ue78NHPz7A5bu7mKgB7buD/6 I4Q843Z5dQQ8dBzkxqnHMd1Xqw== X-Google-Smtp-Source: ADFU+vvLMxRxH/h7CkAFdJYTRIUxoHOGdXhB4XWO+KEcA1CULQxnZQBkrLIxv0PnQ5DaZbEhgZQlFg== X-Received: by 2002:a05:620a:1362:: with SMTP id d2mr20879587qkl.120.1584234279754; Sat, 14 Mar 2020 18:04:39 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: [PATCH] Enable sub-second timeout in zsystem flock From: dana In-Reply-To: <20200315005036.45bc846b@tarpaulin.shahaf.local2> Date: Sat, 14 Mar 2020 20:04:38 -0500 Cc: Cedric Ware , zsh-workers@zsh.org Content-Transfer-Encoding: 7bit Message-Id: <7D94A777-6985-43A7-BDFB-704FEE95D2C4@dana.is> References: <20200104184734.ienw42rwq2xu6aap@phare.normalesup.org> <43775C64-0254-45AB-81AB-B04AE80C4416@dana.is> <20200106173030.eb2pg4rhhgysh35r@phare.normalesup.org> <20200111154143.fjtwgfnztqfmkyda@phare.normalesup.org> <20200308183907.mxnhqrr2uflwooax@phare.normalesup.org> <20200314210454.hp562smyqv3ew255@phare.normalesup.org> <20200315005036.45bc846b@tarpaulin.shahaf.local2> To: Daniel Shahaf X-Mailer: Apple Mail (2.3608.60.0.2.5) On 14 Mar 2020, at 19:50, Daniel Shahaf wrote: > I think the invalid value should be included in the error message, > either as a number, or as a string if needed: "flock: invalid timeout > value: '%s'". In my experience, "invalid input" error messages are > easier to consume when they actually say what the invalid input is. > > dana, I see you advocated the opposite approach in 45283. What's your > rationale? I think i was just trying not to seem nit-picky in light of the fact that it didn't previously error-check the time-out value. I agree that including the original input in the error message would be better (and more typical) dana