From: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: ZSH performance regression in 5.8.1.2-test
Date: Tue, 26 Apr 2022 23:31:37 +0900 [thread overview]
Message-ID: <7E5CB0D9-4740-486A-B55E-6EA0530532F9@kba.biglobe.ne.jp> (raw)
In-Reply-To: <CAH+w=7bb+3T5MabhmCS9BwC7XmTxmydxQ5GLy7R7+6f6B7-=EA@mail.gmail.com>
> 2022/04/26 16:01, Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> Try this?
> <sysread.txt>
--- a/Src/input.c
+++ b/Src/input.c
(snip)
+#ifdef HAVE_FSTAT
+ else {
+ struct stat st;
+ if (fstat(SHIN, &st) == 0 && !S_ISFIFO(st.st_mode))
+ rsize = SHINBUFSIZE;
+ }
+#endif
It works for
printf '%s\n' 'echo $$' sh 'echo $$' | zsh
But in theory (yes, just in theory), SHIN can be a socket.
With two terminals A and B (zsh/socket already zmodload'ed):
A% zsocket -l /tmp/tmpsocket
A% zsocket -a $REPLY
B% zsocket /tmp/tmpsocket
A% zsh <&$REPLY
B% printf '%s\n' 'echo $$' sh 'echo $$' >&$REPLY
then on the terminal A:
zsh: lseek(0, -11): illegal seek
Adding !S_ISSOCK(st.st_mode) solves this, of course.
But at least on my Mac the following seems to work also:
if (lseek(SHIN, 0, SEEK_CUR) == 0)
rsize = SHINBUFSIZE;
# Have you found a case in which lseek(SHIN, 0, SEEK_CUR) fails
# when it shouldn't fail, or does not fail when it should fail?
If you think using fstat() is safer then I have no objection.
PS
Either fstat()/S_ISFIFO() or lseek() works when SHIN is a FIFO:
A% mkfifo fifo
A% zsh < fifo
B% printf '%s\n' 'echo $$' sh 'echo $$' > fifo
next prev parent reply other threads:[~2022-04-26 14:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 18:16 Jordan Patterson
2022-04-25 18:56 ` Bart Schaefer
2022-04-25 19:20 ` Stephane Chazelas
2022-04-25 21:27 ` Bart Schaefer
2022-04-26 7:01 ` Bart Schaefer
2022-04-26 8:31 ` Peter Stephenson
2022-04-27 0:33 ` Bart Schaefer
2022-04-27 14:11 ` Stephane Chazelas
2022-04-27 15:02 ` Bart Schaefer
2022-04-27 15:07 ` Peter Stephenson
2022-04-27 15:17 ` Bart Schaefer
2022-04-26 14:31 ` Jun. T [this message]
2022-04-26 15:15 ` Peter Stephenson
2022-04-27 0:55 ` Bart Schaefer
2022-04-27 9:16 ` Jun T
2022-04-27 0:38 ` Bart Schaefer
2022-04-27 9:34 ` Peter Stephenson
2022-04-27 10:28 ` Jun T
2022-04-27 12:42 ` Jun T
2022-04-27 13:58 ` Jun T
2022-04-27 15:25 ` Bart Schaefer
2022-04-27 16:18 ` Jun. T
2022-04-27 19:54 ` Jordan Patterson
2022-04-28 9:53 ` Jun T
2022-04-28 14:56 ` Bart Schaefer
2022-04-28 18:51 ` Jun. T
2022-04-29 0:28 ` Bart Schaefer
2022-04-29 2:25 ` Jun. T
2022-04-26 1:08 ` Bart Schaefer
2022-04-26 3:03 ` Jordan Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7E5CB0D9-4740-486A-B55E-6EA0530532F9@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).