From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8493 invoked by alias); 28 Jun 2018 14:52:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43110 Received: (qmail 6097 invoked by uid 1010); 28 Jun 2018 14:52:13 -0000 X-Qmail-Scanner-Diagnostics: from mail-io0-f196.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.223.196):SA:0(-1.9/5.0):. Processed in 3.134966 secs); 28 Jun 2018 14:52:13 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIMWL_WL_MED,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Kna+gF6DP4szEv7RNOKs3KiflUPMhRhOb6F1g5abBBs=; b=r4jFFlCrqm/QRkz4W+dzBkUL3XeZ5FmeBIYZgYbggTg27CWJDSeQSRdu2+s1nT8vb6 ug07unaoPSGXHesy7xOg3fA5kVWRe3OCZJkvxfwTCBh2EbE+GT4jxSfVBrc5waKzswur wZ5s574nVf6TKs6yF/5qqeDEoxsMW/XRsqLrFET2tavZcVcqI4TY7+QoctLp9AAIzRFf 0OrcOWXTA+2QnsZ3HxgZGfONAPicvhcv0clIak6VyfN17vbEFM0749m6FOR6Ylc/TEEP oz+d3T/8Zj89vcGrk0raVN77+wyuULHk+SQRFq3PyRy91+FjdB6GToUi8adePmj5vP89 uTNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Kna+gF6DP4szEv7RNOKs3KiflUPMhRhOb6F1g5abBBs=; b=TBc2ANVTiFgseCfiaW4j9Ial6WKBXt869aJBpq/AV3LXMiEZYpxJAZgXI1ZtYfAoRd eb7jqshFvks6r9uTc/TkreqoJTrR68J7jJLZq39xr87qVKfsj2COh4vXeu0iA4yyMwql JA1wrQ7U2H1e0wGVgpNT3lK+beqmA9dv0JonCf1pxIt+xulP7CiiID1InnzU/3NUs2y8 zm629ZZ0u62+QRaPcbBdHwL1v3e8uvYNOHH8jwFFjBjiLrJr01TOvEVrMJw3LQSsyEVs YPQFs0bI4E0a10NJCvFsaSAPwgFmZLBK6mn9H2lQb7yhzv8EkN5O5u1HGqXJv6XBYya5 NjUw== X-Gm-Message-State: APt69E0sFw2s7FnM28V22b/hIWovTcYbZVDlnMztEOSoS+301SP2F4yw xJ1Nw/+KlkANmIZL8AeeuR4aqg== X-Google-Smtp-Source: AAOMgpfhps/C4NNFVco6bJVthOL96OiewJS7dsEmNB5iEfTm/4XIfj65ZsHhDaU7HW3krFelXpkEVQ== X-Received: by 2002:a6b:e008:: with SMTP id z8-v6mr8694538iog.296.1530197527681; Thu, 28 Jun 2018 07:52:07 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: [PATCH] rewrite _killall From: dana In-Reply-To: Date: Thu, 28 Jun 2018 09:52:05 -0500 Cc: zsh-workers@zsh.org Content-Transfer-Encoding: quoted-printable Message-Id: <7EC1FE8D-1B43-4EC2-A787-FC51E5202341@dana.is> References: To: Jun T X-Mailer: Apple Mail (2.3445.6.18) On 28 Jun 2018, at 02:39, Jun T wrote: >+if _pick_variant psmisc=3DPSmisc unix --version; then Is this OK? I know it's checking for killall5/Solaris early on, but is = there any possibility that a SysV-style killall could slip past that check? Maybe = that's overly paranoid, idk. On 28 Jun 2018, at 02:39, Jun T wrote: >+ '(-n --ns)'{-n,--ns}'[match against the PID namespace of the given = PID]:pid: _pids' Trivial thing, but it seems preferable to let _pids, _signals, &c., = handle their descriptions unless there's a specific need to override them, yeah? On 28 Jun 2018, at 02:39, Jun T wrote: >+ '(-g --process-group)'{-g,--process-group}'[kill the process group = to which the process blongs]' >+ '(-s --signal)'{-s,--signal}'[send the speified = signal]:signal:_signals' >+ '-m[interprit specified name as a regular expression]' >+ '-s[show only what will be done, but do notsend any signal]' Some typos here: * blongs -> belongs * speified -> specified * interprit -> interpret * notsend -> not send On 28 Jun 2018, at 02:39, Jun T wrote: >'(-u --user)'{-u,--user}'[kill only processes owned by specified user]: = : _users' >+ '-u[limit to processes belonging to specified user]: :_users' These should all be in -o+ and --opt=3D form, i'd think. On 28 Jun 2018, at 02:39, Jun T wrote: >+ _arguments -s -S : $args `-A '-*'` would be appropriate for this one. dana