From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1391 invoked by alias); 5 Apr 2015 06:19:51 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34847 Received: (qmail 31 invoked from network); 5 Apr 2015 06:19:49 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Biglobe-Sender: Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [RFC PATCH] Allow grouping of thousands in format string From: "Jun T." In-Reply-To: <15444.1428145871@quattro> Date: Sun, 5 Apr 2015 15:19:07 +0900 Content-Transfer-Encoding: quoted-printable Message-Id: <7EDEF535-0ADA-48E6-93EA-E5FBA874F412@kba.biglobe.ne.jp> References: <1428069156-29982-1-git-send-email-oystwa@gmail.com> <15444.1428145871@quattro> To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.1878.6) X-Biglobe-Spnum: 56700 2015/04/04 20:11, Oliver Kiddle wrote: > Anyone have an OpenBSD system they can verify with? Even if it > doesn't support the flag, it'd be good to know if it is just ignored = or > causes printf to fail. The flag is locale dependent anyway so being > ignored is quite reasonable for zsh's printf. On OpenBSD 5.6, the ' flag (grouping) is silently ignored. It has no effect but causes no error. BTW, if we are going to use the patch by =C3=98ystein Walle, the array = flags[] defined at builtin.c:3736: int flags[5], *len; must be flags[6]. (or allocate it by using sizeof(int)*strlen(flagch))