From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 5da0b026 for ; Fri, 8 Mar 2019 20:23:33 +0000 (UTC) Received: (qmail 15866 invoked by alias); 8 Mar 2019 20:23:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44104 Received: (qmail 12085 invoked by uid 1010); 8 Mar 2019 20:23:14 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25376. spamassassin: 3.4.2. Clear:RC:0(66.111.4.26):SA:0(-2.6/5.0):. Processed in 5.37577 secs); 08 Mar 2019 20:23:14 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=message-id:in-reply-to:references:date :from:to:cc:subject:content-type; s=fm2; bh=HS4zObOF/mHFqSnZK79X LTvrHNue4A9iO2uxQzR2tag=; b=JY34PPFSBDOYAlQPXZYpH+YnsTDiFEycJGpv M2k0/646cX8FEzeLwOE0RSVRGauI96taxdmpBO28RXJ5GuCQ48sLlS+wMk+GYx9A J8WCCHBG7pQIIXCcb7kAjLw+oCkppKosLp7O83Pw3LMKG81jin/Jv2wtV0dlI3c5 ZS+4EpDIH2IWw3x/ZEgpiIU6SuhSttOP0Wnt/P9xadAntXCvAC5bkSCZlGzVuCnv TCmdJeWxrxSWnFlur4KeGijyF0BIp/bQngWmUwf7FDSjqZCj0/IuUSM7kilMTjYL 8GxyagvDJHAVciLCVwY7NmcneOs3KY/ih+LwVi1Bv4Nt04KOZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:references:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HS4zObOF/mHFqSnZK 79XLTvrHNue4A9iO2uxQzR2tag=; b=S2ioRjxhzcfyJFgcoK7hw6vXVFsGLFAXE ic3hsQtPGQFm7lGuJu8jhlGN1uFbDggUOmC3dBchLbQcyYEL617GZaX7KEnVDrjl XmnqP6ztChvXPbl3YFsFJSQONH3weEC9tVRFUi1k8l3EG4nx4P2zysrh3VZLGzjE xcc/Ydoz6jxBLGaOZIwUjZuIOX/co3lV/tnoSF+Xmo5m4qV7vhYtJKalf2irJeVO mT7IEFlQtmbfG5cuo1mdm3Sj7J08g5HlXsX5I+XlOaSlD0cbjMGCplLaNWhKhMi+ d+xNAhrVPkSQQP3OPOoAtzIzDXzmOyYYbgYdQnj4lTqlgFszkoGJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrgedtgddufeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgfkjghffffhvffutgesthdtre dtreerjeenucfhrhhomhepfdffrghnihgvlhcuufhhrghhrghffdcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurd hssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.5-925-g644bf8c-fmstable-20190228v5 X-Me-Personality: 3897223 Message-Id: <7a2210af-0a67-4289-86c2-388e67eff32e@www.fastmail.com> In-Reply-To: References: <20190307192305.GA3173@av.sy.gs> Date: Fri, 08 Mar 2019 15:22:31 -0500 From: "Daniel Shahaf" To: dana Cc: zsh-workers@zsh.org, "Adrian Vollmer" Subject: =?UTF-8?Q?Re:_Bug_in_git_tab_completion:_If_git.showSignature_=3D_true_i?= =?UTF-8?Q?s_set_globally,_tab_completion_of_commits_is_garbled?= Content-Type: text/plain X-Qmail-Scanner-2.11: added fake MIME-Version header MIME-Version: 1.0 dana wrote on Thu, 07 Mar 2019 23:28 +00:00: > On 7 Mar 2019, at 13:23, Adrian Vollmer wrote: > >to reproduce this bug, set showSignature = true in the log section of > >your global git config file, then type git reset in a git repo > >that has a recent signed commit in its history. > > I guess this is the simple fix for this particular case. `git log` is called > in a few other places, too, but i'm not sure if they're problematic. Probably > are and i just don't know how to trigger it. > > Maybe it would make sense to do something more robust instead, though? For > example, we could have a __git_call wrapper around _call_program that always > calls git with a safe set of -c options, &c. It'd be a lot of lines changed, > but any further issues like this could be fixed in one place. idk. > Should we use git-rev-list(1) instead of git-log(1)? The former is a plumbing command, so should be the more appropriate interface for this use-case. My git(1) does not have the log.showSignature option so I couldn't test this. (The knob is missing from _git-config() too.) Cheers, Daniel