From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21060 invoked from network); 16 Sep 2022 12:03:56 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 16 Sep 2022 12:03:56 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1663329836; b=gwo+ZyGBU4WpOO9Z57FN79J2erMq4XRwOVvzBxlynr4+ncHp8vM6N416QZfDbAmwLN7d/sRiZ7 h4DiXKR3WRzlwbYJUfcJXUC3BnApbydC+JYHs9G50DtAq5fkF6oaFu4qOL6jCuQuSxKgefd56o bQD0jJ+ZnTE1mCbEVPd7iebvfwoLBZ6i+Cd8W8LZsFP3kA8iq04j7haLPwSWdG4x4dUZXRPWmn jlg3d7A7YbsN4gEiQHnXqSsP3PFqsEgvhNbQqAwiLjCgxs9cxj4U879wlteu6sGiujxwgIRiCs MB7cPov4eLFtktb/4NzynZaEQUPS1PJlwOAfE6oRvh8L3A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-qv1-f48.google.com) smtp.remote-ip=209.85.219.48; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1663329836; bh=S30YqKYsbh9o1LbHOM6i4K3u5tkuEprOcBIjXWOGaMM=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:DKIM-Signature: DKIM-Signature; b=mwlc9abEcNtEcZcFSTxswZzwX+ERziFhs6d4DBHDiaX8OrkVqEBCKRvlsfBgWX/lL9/4PqPJ8L 4vMFZhVWuvblZ2wa3wJvGFURq7O7LR1Qj+xqChrCysjnjioMIiDJtHIgu/PDhKLn3ayrP9BgB8 C9VmVBkSTd/CHViYdt93o+1GC8SaQmPaqSSA18vvOMBk7n3aLtpZXGXFtbg/SQ8EvJ8gP8J21F H12u60nfmQ0rBIrbgxNZzUtGtGIKfrBne26dNsI77xkp6wo4FNqQOzgN3p3PjWWoWjUTwnNitO suULK4sshWd61dfpZepjWL56/zlP4P41wWIJTCZByhbFWA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=7zuJ/MYNp8jRk9yOvKljil2+0XzhbYRl+a8gq5tSPgo=; b=j6W+VCRdbBHP5HQmJRBUc/eDdB OWTISZoTIaC2PNeXJUUJ6pve2r0h78NVkD66KRYCtFllYBkTd033fV967PXpdZMCJg7dN5BaaQNCc JiD/NNDfApX91Z1BryY2JPZiskGOTnytwFHmha0hnI0b2FHj/Difn/plnmIX2EwcPba2c/5X9VbHj 1QNC+gshq1/A38rwP9TBisC8ZH0WwVN7HHnCIE9NVeZ5C+o5oSo53PQHFWDNpERybDw+3Jozfhp4v toyzhvCkD2653DPhfkYZbtcCrAsT7WaPxGc6qhaK0cBAJBq/aZjDJmCQT+KfLzxiMiTv6XgkjV4rF P8h4FIew==; Received: from authenticated user by zero.zsh.org with local id 1oZA4Z-000Hlx-GE; Fri, 16 Sep 2022 12:03:55 +0000 Authentication-Results: zsh.org; iprev=pass (mail-qv1-f48.google.com) smtp.remote-ip=209.85.219.48; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-qv1-f48.google.com ([209.85.219.48]:45940) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oZ9ys-000Gnb-Jb; Fri, 16 Sep 2022 11:58:03 +0000 Received: by mail-qv1-f48.google.com with SMTP id o13so16423543qvw.12 for ; Fri, 16 Sep 2022 04:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=7zuJ/MYNp8jRk9yOvKljil2+0XzhbYRl+a8gq5tSPgo=; b=BpR0e3cOEZkx2HxeD1r3OSuaKIlcprdlpeJUBRUMFL5XazXFfpJ1lIrx2ZJ1GkouMG V//WW7mJPdlBFs53srciU7/7au1CghICpy12oS57K4nzgnYhai2jdpSMTCzzxHkWUOqn Ifz5jlPhahkTmQ0Xd21Y4ymxkiNsG6lkVoPwqCS/ZYALK6Cp4Q0kPFKNbSADX3m7wS8p lQMgGPuB7aYkSjV9RAyc9j4EOdmrhtj+Ujbxpk8Lyz07GQgPhRnDBKkrMau/Ceatyh6Q UlUcvAKrjdsF5w2OU52uUvyVN1vVxMf1d/vH/qcgBkjyfXYqkM+N4h9Vvsa33EKXZb/L ktBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=7zuJ/MYNp8jRk9yOvKljil2+0XzhbYRl+a8gq5tSPgo=; b=XNIEiv4vctkAPWxKry8bIv2j1o+QP4Zw1Hg2kYIjToKsISMAg4WjWrmN/yvw5+fzr4 FIdfoSIVW7nYZgqZ4bGMu7wvRSqhzC4XPRg9OhXx7zDQpBD0b9tO3dc8dvFdM0Yav3/l j94utUR48pKCAlO0MZubAhUcwWsWdMgK67BEkvTHlOEgLmnr6Q3/cD1030uCsPrmnxyX BHVbvBamvLc9IQOhwh2ySPeHuqjxrbTYZFNtG6cEr11l4gcWZMN8OxAh4FXrkFM/LxIr Rz7Cy20ca13wCh/axQZlCVh65Tzv9szK3uANCt2gUTB+DmOwFnBmc5LOJGcN/MGNY+jT prLA== X-Gm-Message-State: ACrzQf064ipqGN/P//RKbs6VqWVwmdtO97VneeL8jyLLWhE6c+GX9iM9 0GpVzFUwlKSpZQtZcn3c4jc5OLOP8Ss= X-Google-Smtp-Source: AMsMyM57yySGep+d2Ty1JWzRCoPlEXCISl7KFD0wwTgYYcWQ/FVAXkm4Tr6i7rMstIJ71FM5okLN5g== X-Received: by 2002:a0c:cc0b:0:b0:499:212:73cf with SMTP id r11-20020a0ccc0b000000b00499021273cfmr3851776qvk.99.1663329481517; Fri, 16 Sep 2022 04:58:01 -0700 (PDT) Received: from ?IPV6:2602:47:d947:3300:8791:411c:47c5:5683? ([2602:47:d947:3300:8791:411c:47c5:5683]) by smtp.gmail.com with ESMTPSA id v6-20020a05620a440600b006bb87c4833asm6660286qkp.109.2022.09.16.04.58.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 04:58:01 -0700 (PDT) Message-ID: <7a361688-0dc1-7971-0990-0a5b71f226fa@gmail.com> Date: Fri, 16 Sep 2022 07:58:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Fix configure test build errors with clang-15 Content-Language: en-US To: Jun T , zsh-workers@zsh.org References: <20220915023624.3384-1-nvinson234@gmail.com> <42865334-AA03-4552-8CEB-89E41CD44E05@kba.biglobe.ne.jp> From: Nicholas Vinson In-Reply-To: <42865334-AA03-4552-8CEB-89E41CD44E05@kba.biglobe.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Seq: 50642 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Changes applied. I've sent the new patch to the mailing list. Thanks, Nicholas Vinson On 9/16/22 05:33, Jun T wrote: >> >> 2022/09/15 11:36, Nicholas Vinson wrote: >> >> When building with clang-15.0.0, I discovered several configure tests >> incorrectly fail because clang-15.0.0 errors with messages similar to: >> >> "error: type specifier missing, defaults to 'int'" >> >> and similar such errors. These failed tests ultimately cause zsh to be >> built incorrectly, and can cause commands such as eval to hang >> indefinitely. For an example of this behavior please see >> https://bugs.gentoo.org/869539. This patch fixes the configure tests, so >> they do not incorrectly fail. > > Thanks. > > Could you please include the following changes to your patch and test again? > The changes are: > (1) remove (most of) > #include > which were added in commit bd647c156 to get the prototype of exit(), > (2) replace a few remaining exit() by return. > > The patch below assumes that your patch is already applied. > > > diff --git a/aczsh.m4 b/aczsh.m4 > index 2cfb4e5db..b31236020 100644 > --- a/aczsh.m4 > +++ b/aczsh.m4 > @@ -119,7 +119,6 @@ AC_TRY_COMMAND($DLLD -o conftest1.$DL_EXT $LDFLAGS $DLLDFLAGS conftest1.o $LIBS > AC_TRY_COMMAND($CC -c $CFLAGS $CPPFLAGS $DLCFLAGS conftest2.c 1>&AS_MESSAGE_LOG_FD) && > AC_TRY_COMMAND($DLLD -o conftest2.$DL_EXT $LDFLAGS $DLLDFLAGS conftest2.o $LIBS 1>&AS_MESSAGE_LOG_FD); then > AC_RUN_IFELSE([AC_LANG_SOURCE([[ > -#include > #ifdef HPUX10DYNAMIC > #include > #define RTLD_LAZY BIND_DEFERRED > @@ -202,7 +201,6 @@ AC_TRY_COMMAND($DLLD -o conftest1.$DL_EXT $LDFLAGS $DLLDFLAGS conftest1.o $LIBS > AC_TRY_COMMAND($CC -c $CFLAGS $CPPFLAGS $DLCFLAGS conftest2.c 1>&AS_MESSAGE_LOG_FD) && > AC_TRY_COMMAND($DLLD -o conftest2.$DL_EXT $LDFLAGS $DLLDFLAGS conftest2.o $LIBS 1>&AS_MESSAGE_LOG_FD); then > AC_RUN_IFELSE([AC_LANG_SOURCE([[ > -#include > #ifdef HPUX10DYNAMIC > #include > #define RTLD_LAZY BIND_DEFERRED > @@ -278,7 +276,6 @@ AC_TRY_COMMAND($DLLD -o conftest1.$DL_EXT $LDFLAGS $DLLDFLAGS conftest1.o $LIBS > AC_TRY_COMMAND($CC -c $CFLAGS $CPPFLAGS $DLCFLAGS conftest2.c 1>&AS_MESSAGE_LOG_FD) && > AC_TRY_COMMAND($DLLD -o conftest2.$DL_EXT $LDFLAGS $DLLDFLAGS conftest2.o $LIBS 1>&AS_MESSAGE_LOG_FD); then > AC_RUN_IFELSE([AC_LANG_SOURCE([[ > -#include > #ifdef HPUX10DYNAMIC > #include > #define RTLD_LAZY BIND_DEFERRED > @@ -349,7 +346,6 @@ AC_TRY_COMMAND($DLLD -o conftest1.$DL_EXT $LDFLAGS $DLLDFLAGS conftest1.o $LIBS > save_ldflags=$LDFLAGS > LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS" > AC_RUN_IFELSE([AC_LANG_SOURCE([[ > -#include > #ifdef HPUX10DYNAMIC > #include > #define RTLD_LAZY BIND_DEFERRED > @@ -424,7 +420,6 @@ elif > save_ldflags=$LDFLAGS > LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS -s" > AC_RUN_IFELSE([AC_LANG_SOURCE([[ > -#include > #ifdef HPUX10DYNAMIC > #include > #define RTLD_LAZY BIND_DEFERRED > @@ -493,7 +488,6 @@ echo 'int fred () { return 42; }' > conftest1.c > if AC_TRY_COMMAND($CC -c $CFLAGS $CPPFLAGS $DLCFLAGS conftest1.c 1>&AS_MESSAGE_LOG_FD) && > AC_TRY_COMMAND($DLLD -o conftest1.$DL_EXT $LDFLAGS $DLLDFLAGS -s conftest1.o $LIBS 1>&AS_MESSAGE_LOG_FD); then > AC_RUN_IFELSE([AC_LANG_SOURCE([[ > -#include > #ifdef HPUX10DYNAMIC > #include > #define RTLD_LAZY BIND_DEFERRED > diff --git a/configure.ac b/configure.ac > index 958ac7cd7..074141d38 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1369,7 +1369,7 @@ zsh_cv_func_realpath_accepts_null, > #include > #include > ],[ > -exit(!realpath("/", (char*)0)); > +return(!realpath("/", (char*)0)); > ])], > [zsh_cv_func_realpath_accepts_null=yes], > [zsh_cv_func_realpath_accepts_null=no], > @@ -1393,7 +1393,6 @@ AC_CACHE_CHECK(if tgetent accepts NULL, > zsh_cv_func_tgetent_accepts_null, > [AC_RUN_IFELSE([AC_LANG_SOURCE([[ > #include > -#include > int tgetent(char *, char *); > char *tgetstr(char *, char **); > int main() > @@ -1421,7 +1420,6 @@ AC_CACHE_CHECK(if tgetent returns 0 on success, > zsh_cv_func_tgetent_zero_success, > [AC_RUN_IFELSE([AC_LANG_SOURCE([[ > #include > -#include > int tgetent(char *, char*); > char *tgetstr(char *, char **); > int main() > @@ -1869,7 +1867,6 @@ zsh_cv_rlim_t_is_longer, > #include > #endif > #include > -#include > int main(){struct rlimit r;return(sizeof(r.rlim_cur) <= sizeof(long));}]])],[zsh_cv_rlim_t_is_longer=yes],[zsh_cv_rlim_t_is_longer=no],[zsh_cv_rlim_t_is_longer=yes])]) > if test x$zsh_cv_rlim_t_is_longer = xyes; then > AC_CACHE_CHECK(if rlim_t is a quad, > @@ -1880,7 +1877,6 @@ if test x$zsh_cv_rlim_t_is_longer = xyes; then > #endif > #include > #include > -#include > int main() { > struct rlimit r; > char buf[20]; > @@ -1903,7 +1899,6 @@ else > #include > #endif > #include > -#include > int main(){struct rlimit r;r.rlim_cur=-1;return(r.rlim_cur<0);}]])],[zsh_cv_type_rlim_t_is_unsigned=yes],[zsh_cv_type_rlim_t_is_unsigned=no],[zsh_cv_type_rlim_t_is_unsigned=no])]) > if test x$zsh_cv_type_rlim_t_is_unsigned = xyes; then > AC_DEFINE(RLIM_T_IS_UNSIGNED) > @@ -2187,7 +2182,6 @@ zsh_cv_sys_fifo, > #include > #include > #include > -#include > #include > int main() > { > @@ -2200,7 +2194,7 @@ int main() > #else > if(mknod("/tmp/fifo$$", 0010600, 0) < 0) > #endif > - exit(1); > + return(1); > pid = fork(); > if(pid < 0) > return(1); > @@ -2289,7 +2283,6 @@ zsh_cv_sys_link, > [AC_RUN_IFELSE([AC_LANG_SOURCE([[ > #include > #include > -#include > int main() > { > int ret; > @@ -2322,7 +2315,6 @@ zsh_cv_sys_killesrch, > #include > #include > #include > -#include > int main() > { > int pid = (getpid() + 10000) & 0xffffff; > @@ -2348,7 +2340,6 @@ if test x$signals_style = xPOSIX_SIGNALS; then > [AC_RUN_IFELSE([AC_LANG_SOURCE([[ > #include > #include > -#include > int child=0; > void handler(sig) > int sig; > @@ -2400,14 +2391,13 @@ case "x$zsh_working_tcsetpgrp" in > #include > #include > #include > -#include > int main() { > int fd; > int ret; > fd=open("/dev/tty", O_RDWR); > - if (fd < 0) exit(2); > + if (fd < 0) return(2); > ret=tcsetpgrp(fd, tcgetpgrp(fd)); > - if (ret < 0) exit(1); > + if (ret < 0) return(1); > return(0); > } > ]])],[zsh_cv_sys_tcsetpgrp=yes],[ > @@ -2775,14 +2765,13 @@ elif test "x$dynamic" = xyes; then > zsh_cv_sys_elf, > [AC_RUN_IFELSE([AC_LANG_SOURCE([[/* Test for whether ELF binaries are produced */ > #include > -#include > #include > int main(int argc, char *argv[]) > { > char b[4]; > int i = open(argv[0],O_RDONLY); > if(i == -1) > - exit(1); /* fail */ > + return(1); /* fail */ > if(read(i,b,4)==4 && b[0]==127 && b[1]=='E' && b[2]=='L' && b[3]=='F') > return(0); /* succeed (yes, it's ELF) */ > else > @@ -2928,7 +2917,6 @@ EOM > AC_TRY_COMMAND($DLLD $LDFLAGS $DLLDFLAGS -o conftest.$DL_EXT conftest.o 1>&AS_MESSAGE_LOG_FD) && > AC_RUN_IFELSE([AC_LANG_SOURCE([[ > #include > -#include > #ifdef HPUX10DYNAMIC > #include > #define RTLD_LAZY BIND_DEFERRED > @@ -2960,7 +2948,7 @@ int main() > void * handle ; > void * symbol ; > FILE *f=fopen("conftestval", "w"); > - if (!f) exit(1); > + if (!f) return(1); > handle = dlopen("./conftest.$DL_EXT", RTLD_LAZY) ; > if (handle == NULL) { > fprintf (f, "dlopen failed") ; > > > >