From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 12905 invoked from network); 4 Apr 2021 16:27:26 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Apr 2021 16:27:26 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1617553646; b=braQFKHmLPXeBoeYOetayzileaw4nQwwdnqkhfz0O6nwsocijwoWWg+GCvvQTDM4rP8p9vZy7/ XZ/cMvEahJ2dSOUjxm1n/m3Y39WmUWoUV9k6jNeG2rOZiX+Y+kF8r30MLt2rJY14gzTq0gGf72 kbbBtqxeukpOJHK5PuripyPHqXSG63jwJKNpWA8tD+LDIrM6kov+w20uPGFt/hqW/g3Nfa4owH NE27AnWHBRUvnnFwN6u8RY4z9r2ZRqBjVbqKNYa71xWyYD20Sdr7je5QhZYce0rpYU7YXjcPUk 4daJGUWCvMLBRoa75e+6+eeryTicbXbGjSmXQkbGGSJtpg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (know-smtprelay-omc-6.server.virginmedia.net) smtp.remote-ip=80.0.253.70; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1617553646; bh=KFkizLmKu4lbqKYDC20Nd5mLhJKm1170hSm8gySLpC8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:MIME-Version:Content-Type: References:In-Reply-To:Date:To:From:Subject:Message-ID:DKIM-Signature: DKIM-Signature; b=k6vgnm+nWXxxSu/JHVtcv4mYJkr2XOFgd53iLtrtBEe8Fv/gh7EYcWanrqBilnvIa8Aib1dalN GYt3rAv4/mhYaE3gqfNZG6cHiRP+XVUhg1rMZZ6nSylJ1qzUHSbfoA4KUM7IQxMPhGc53Ml29k D7TW7T+LxW/BLu3e4rgL5kqZpcC4jUJA62sqH4NtVttA5VjvvF+wINy8N9hhSZY44kLWtH8JI0 h97TXoHQOmunN60+jtL+N/CohI3XX8mUk/gtYoU5tzWEiwCCwdNOVOSNHiZ+zzChjo9WUCyJW4 r8cM7yb4SSUMUoxFccJSWTShuhZxeOTWoLjMvbIB33LZHQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Mime-Version:Content-Type:References:In-Reply-To:Date:To:From:Subject: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=ZjUJ3LwJE1jVjyAPwMxQT2JR0FTPJWWe+/JDLVoaXBo=; b=FzzjiAUPCgNA1gtW6L/T2bpUy2 V746FykNCQnhTtxnkiBZUk6s+HO3HccEOSi8S/ED6f/gJtA22wJWxRgVbJ4yAyhSQ3JSrJzQm9xsA oi86I8HhfxWxj8AQjHB88Cp8uyx5IBJtaEeNM+pfuiqw/OaUm0eXR+vrMs3q9U9dy5DfvVK3GCLD5 1vxzWUT5XXjntbdIFsp+3/kaRLH04DRP8q/t8O8Qtdd4Bv8VTimGaXZ6PzyBFsYjaytvQo/XkvwTA Pda5YPJUkSotgX7l7EGbxfI8EhznW3EcgPm/3JSWP0zqP9zdvWVHEk0WcavndCUh+IVasrzMHk32l 7AJsf0YA==; Received: from authenticated user by zero.zsh.org with local id 1lT5av-0007lg-NC; Sun, 04 Apr 2021 16:27:25 +0000 Authentication-Results: zsh.org; iprev=pass (know-smtprelay-omc-6.server.virginmedia.net) smtp.remote-ip=80.0.253.70; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from know-smtprelay-omc-6.server.virginmedia.net ([80.0.253.70]:58108) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1lT5ac-0007dX-3t; Sun, 04 Apr 2021 16:27:07 +0000 Received: from pws-Zeus ([82.20.19.64]) by cmsmtp with ESMTPA id T5ablbw1Dt62LT5ablvDNF; Sun, 04 Apr 2021 17:27:05 +0100 X-Originating-IP: [82.20.19.64] X-Authenticated-User: p.w.stephenson@ntlworld.com X-Spam: 0 X-Authority: v=2.3 cv=LL5Ivqe9 c=1 sm=1 tr=0 cx=a_exe a=FYxK54AnRTbDA0SLc6W5Eg==:117 a=FYxK54AnRTbDA0SLc6W5Eg==:17 a=YKbIQ49y8z0OK5oo:21 a=IkcTkHD0fZMA:10 a=rAA90CKOPfjQ-1UNH1UA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ntlworld.com; s=meg.feb2017; t=1617553625; bh=ZjUJ3LwJE1jVjyAPwMxQT2JR0FTPJWWe+/JDLVoaXBo=; h=Subject:From:To:Date:In-Reply-To:References; b=CT24R5qRkfW0mfStznIw3PrGMvq52S3nCEf6vT1CkiTqN0+3B4Ky9+YC3LlMxH88g 0/ceyJZB5uyZka/ytV7nc0A281w90TCihGUeMnDumQsnfxrcwvrw8JhCsWSmrcTpuH e9XK5ZCIBZIm4LPKah83ogukWvp156/cybzrCegsH5jTBjP9mRfvRzk9xl1RM75Z00 lxhwvoTjN69Lsk0y73fdPJ9z88Hn/1O2Z4MOTHA2Ss9NndaCRMjhapT6KBpMBR45Lz Bwvw9m0gzLEDhZJFYrOzbRq2X1IzwOy6sn9H35ujDyYgibnk9/Xjz/O7S5QAEEw/X8 q0k+9cUvS6AZg== Message-ID: <7a5b055845089cfd55bb0a37fce66a5cbc47c9d5.camel@ntlworld.com> Subject: Re: [PATCH] Make the parameter expansion subscript flags parse error message, "error in flags", identify the location of the parse error. From: Peter Stephenson To: zsh-workers@zsh.org Date: Sun, 04 Apr 2021 17:27:05 +0100 In-Reply-To: <20210403024954.4321-1-danielsh@tarpaulin.shahaf.local2> References: <20210403024954.4321-1-danielsh@tarpaulin.shahaf.local2> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfAYOY8KWBiwlb5H9Q1H9Xb6h4+/JS63BR8jTHLDZTVMIg68Wk97x4Ew4Jt0QcCqHMLfdVuwPlO4TrdkmgF+9cWs4GY1/YhRIiSb+LRaOrvrtA7+PqNd7 rT4PKy75PYTnla3zGI5Zsg6fAUxKPmpLuAlbRwSfpL4cbz3mfA72Fkee X-Seq: 48392 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Sat, 2021-04-03 at 02:49 +0000, Daniel Shahaf wrote: > --- > Review of the logic obtaining and massaging str_copy_for_output would be > appreciated. It's a 2500-line function and there are multiple char* > variables that refer to the same memory locations as *str, so it's > conceivable I overlooked something. I think this is early enough in the function it should be fine. It's moving from left to right except where it needs to find something matching, and the flags are first. pws