From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 32462 invoked from network); 19 Jun 2020 22:49:36 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 19 Jun 2020 22:49:36 -0000 Received: (qmail 23703 invoked by alias); 19 Jun 2020 22:49:27 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46080 Received: (qmail 5938 invoked by uid 1010); 19 Jun 2020 22:49:27 -0000 X-Qmail-Scanner-Diagnostics: from indus.uberspace.de by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25842. spamassassin: 3.4.4. Clear:RC:0(95.143.172.201):SA:0(-1.9/5.0):. Processed in 4.675675 secs); 19 Jun 2020 22:49:27 -0000 X-Envelope-From: me@manueljacob.de X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at manueljacob.de does not designate permitted sender hosts) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 20 Jun 2020 00:48:41 +0200 From: Manuel Jacob To: Daniel Shahaf Cc: zsh-workers@zsh.org Subject: Re: vcs_info patch-format/applied-string awareness? In-Reply-To: <20200619104626.6689220f@tarpaulin.shahaf.local2> References: <20200607074445.7723-1-me@manueljacob.de> <20200607121443.7c58ee16@tarpaulin.shahaf.local2> <20200608053140.33e79354@tarpaulin.shahaf.local2> <538786d4a3afe4b9432a1469ebafcad8@manueljacob.de> <20200609223416.59a43074@tarpaulin.shahaf.local2> <20200617082743.12b5d092@tarpaulin.shahaf.local2> <20200619100731.099deac3@tarpaulin.shahaf.local2> <20200619104626.6689220f@tarpaulin.shahaf.local2> Message-ID: <7e4c25be62ac90418bb582b344bbcfba@manueljacob.de> X-Sender: me@manueljacob.de On 2020-06-19 12:46, Daniel Shahaf wrote: > Daniel Shahaf wrote on Fri, 19 Jun 2020 10:07 +0000: >> Manuel Jacob wrote on Fri, 19 Jun 2020 04:06 +0200: >> > I’m concerned that most people won’t use the feature because they’re >> > not aware that it exists. >> >> Fair point. Let's first see if we can enable the feature without user >> interaction at all. If that doesn't pan out, then we can see about >> addressing the lack of awareness. > > By the way, I think this point applies to the "show patch series" > functionality too. That functionality is used by several vcs backends > (e.g., quilt, hg mq, git rebase), but is not enabled by default and > I suspect many people don't know it exists. > > I'm referring to this: > > [[[ > $ cd Functions/VCS_Info/ > $ rm -rf vcs-test/ > $ zsh ./test-repo-git-rebase-apply > ⋮ > CONFLICT (content): Merge conflict in iota > ⋮ > zsh: exit 1 zsh ./test-repo-git-rebase-apply > $ (cd vcs-test/ && zsh) > myref/rebase/+ f973ee0a1fe5 > [5+2=7] ea03c123a587 r7: Append a line > % > ]]] > > See the "[5+2=7] ea03c123a587 r7: Append a line" line. (That line was > generated by setting zstyles to values such as those given in comments > at the top of ./test-repo-git-rebase-apply, plus some fine-tuning by > zshrc hooks.) > > So, should we have patch series information displayed by default? The > information about applied patches is parsed by default, but not shown > by default because the %m expando isn't in the default > formats/actionformats > values. > > Or alternatively, should we increase awareness of it? MQ is deprecated and discouraged and any support for it doesn’t need any more awareness. Personally, I neither want to spend time thinking about how to improve MQ support nor answer any questions from MQ users that keep using it because zsh support improved. ;) > Cheers, > > Daniel > > P.S. The hg backend doesn't seem to support equivalent functionality > for the rebase/histedit commands; see the VCS_INFO_set-patch-format > call. > hg mq support is present but not enabled by default.