From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 33eb9356 for ; Tue, 13 Nov 2018 11:29:58 +0000 (UTC) Received: (qmail 10897 invoked by alias); 13 Nov 2018 11:29:44 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43822 Received: (qmail 14806 invoked by uid 1010); 13 Nov 2018 11:29:44 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(205.235.26.22):SA:0(-1.7/5.0):. Processed in 3.643004 secs); 13 Nov 2018 11:29:44 -0000 X-Envelope-From: SRS0=OWCg=NY=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1542108556; bh=Ry8J/zJ7CTn2ER5XdbOmVSwFSEz7o6tZKwtP72dY0j8=; h=From:References:To:Subject:Date:From:Subject; b=gkzbe6K6a6EzPf7d0XcRU18+cQ07kJ3GVF89Tisfa+df6Rvk/3982f65K5SCX2sE8DBcdPqVLOFFoFnZ72nX1yqj5GWXOMyBTj0RbaH5gyutszicyZU/fSb7vBk5/k8PpWUDTq+2nYsX1P3kZExgknyemrTvtHJXxLUSBhcnFBV2dloVo+WR2O9FC17DlLQaacGmmB8vB7QYWf5dFiJGmIQE4HAQwKhOuFfi2pvIzbrrgx8LSoVuZLpA6B+n4X2xZRVqAZ3O6/KLTl0pbeVX8eb+3tKGKAFCWquTNMxKkm++SD9zpeMtXnDDInDNoRqElj7oPPpoRPN1aviECsnqGA== X-YMail-OSG: twYSo10VM1lxWQ7OjkwBZCwLht3GcyudbdSIsEtlFWqRcA.KE4FrhQ8.FR4lARD XKqqMBxSwVnLGNrRcO_a3TR4EpAc7H5U_j.4KLlounl_mK9FAIhaDya_Z27c3OHwOzaCHd8pQcIU kFU7R2c9ljLNT9Scy.4YtUlLXyqjnEJgzH.estTe98xWCeJiZkZ.Peftabknll.CN7FYKpDu7iUM OgX9DbcL25Nno1xZZ7ENRSvBfArrrznR4U10mPpEC_zPMXDdPomX5TY12o92na7DvaMkbTFyhHwu bJT7gAIOumPCkC4q0MVFPAu1JO_UJBKHMLSPY2STP1Cn3QiTiYMkvn1.gcwNMK0MTkH2_XOKDvqN LSRKPcCkp0yYzaC..FXYG.HRVMtv9Fr6Sbu950QbnMYPA0FcWGZjNTkojZDKj4V2GrOopYksNxEI K.W13J8v3PNKZcakRNhrNKMNeagAFIV.KK62KrGM1OdPCYaftY87BDrjX_woY7.blFlMqJYLv5Q2 HBTq6Fl1pdfrOGXjYc5EvnaxJ3K8ca3TnsvBmg9J3bh_r_JOQT.BsaIgRnOWdI.qtJDCifXBvyTa teukG0_UDUnmDnUnh8l9ljxWOUvWELBAmNNACKncYAVQgLffKkNZYxgvzdm7a.MpNKy_0Af7TcNZ DUbjsgeEBNa7SZSKepfqagrYFaTuObr9OFSbIx66ybHy925deXogxt7tYWTouVLycX_aMUrFWzf8 Cwq5DfJqud1gjtS6I43Flgsp0bD.ZmAbFgVHgfMFcGfw5k0XTFpuFKT1S4.YeXfypsDvjcotzxHP sG6EMOO8sZBOXzXz0QK.DdxizrBS_JK5mSVIyiEQ8zfAjLBRrfRSwU.83nQSkTnvk3CxtixjLsDD QyebXyrE8ZDETjMXan9oFAJsr5tFNSUeeNdx2Fwe38AY5u8IpngkaWWarfrhYuRflK4zWL1kKyOr UmlXJQ4QKv9weyWiddUxR29OEwFqX2FeMHpG2WzN_GjfRfjAo9q26FWfOIcXkXSv5KA0rYhF_W8x 2puDNisrabmM1ocM- cc: Zsh workers In-reply-to: From: Oliver Kiddle References: <48216-1541900650.063823@-d-s.vJ6h.N9Zv> To: Mikael Magnusson Subject: Re: PATCH: allow multiple completion for gcc -Wsuggest-attribute MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <80821.1542108552.1@hydra> Date: Tue, 13 Nov 2018 12:29:12 +0100 Message-ID: <80822-1542108552.248661@XFOT.4sV7.4WEJ> Mikael Magnusson wrote: > Is there a specific reason you changed "Warn" to be lower case > inconsistent with all the other descriptions here? Lower case is the normal convention for completion functions and I apply corrections for common things like that on lines that I'm otherwise modifying. I can see that in this particular case, it is rather less than ideal because there's a lot of similar options. The trouble with big patches to correct things like case and indentation is that they obscure history in git. In the case of gcc, I'd be inclined to treat warnings as a single -W option that takes an argument: '*-W-[enable/disable a warning]:warning:->warnings' Then parse the output of gcc --help=warnings and strip off the then superfluous "Warn (about|when|if) " part of the descriptions. Oliver