From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Peter Stephenson <pws@csr.com>
Cc: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: kfmclient and MIME type completion
Date: Mon, 26 Jul 2004 17:29:55 +0200 [thread overview]
Message-ID: <8123.1090855795@trentino.logica.co.uk> (raw)
In-Reply-To: <200407261346.i6QDklDr010975@news01.csr.com>
Peter wrote:
> +# This is the same style as used by zsh-mime-setup, with a different
> +# context.
> +if zstyle -a ":completion:${curcontext}:mime" mime-types type_files; then
Why do you use `mime' as the tag? It should either be empty or the same
as the tag used when adding matches (such as mime-types).
> + _wanted mimetype expl 'MIME type' \
The convention is for tags to be plural. We also seem to use hyphens to
separate words so I'd use mime-types and mime-subtypes for the tags.
> +[[ $state = *arg ]] || return 1
> +
> +# Argument to previous command.
> +
> +print $line >/tmp/tmp.out
That looks like remnant debug which we won't want.
Oliver
next prev parent reply other threads:[~2004-07-27 23:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-26 13:46 Peter Stephenson
2004-07-26 15:29 ` Oliver Kiddle [this message]
2004-07-27 9:14 ` Peter Stephenson
2004-07-26 16:54 ` Bart Schaefer
2004-07-28 9:42 ` Peter Stephenson
2004-07-27 11:40 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8123.1090855795@trentino.logica.co.uk \
--to=okiddle@yahoo.co.uk \
--cc=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).