From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7286 invoked from network); 2 Jan 2024 17:05:19 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 2 Jan 2024 17:05:19 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1704215119; b=Dn4E7qenfSoBNkJ54B0h6DGTJCn45VI0skPYprJDgSQyJoaVRSfFRxda5cbX5KX1QgqevRuot8 IjHMbAGuP/orTEf93w9dSTuS+oGGhVbJtJ9kBanUJR4YrvU8gvDRjgZ6hiO65YvGnLDNqEAddV K8xFxLdA3vSjJxncPE8nQI69GAB0o0fBR1gm4mmvxtX6aydQ8ThBQd2B0ewbovZYG4Ww+kMraf WoHigwGN8jNWCH4b72EZzQ5dPclkmQWjVTxOKyUNqA+/BCXYJVL70Lcgn7k/o1XplC/V/+GQFc YZR59bI+59ChZ26qn6kiZGtTD2tkC9Hg0KGWRMFAAs3j1g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (csmtpq4-prd-nl1-vmo.edge.unified.services) smtp.remote-ip=84.116.50.41; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1704215119; bh=bkVjZJPzUGjofMw5L7gehn6xQ6NA0GFZ0nj2xIRqeOs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=icgm6iOcjZ9dIowPy7bRFIjUQ/ezFOcvwxJ+84M1GWuZrxysUJ4mTH+IZowkEnNQcBju73VTs1 KIydv3klVy2BNS4EE1J0CQ1oj20/Z+MA7gPvBpSveogD4HQ7e2/6jy5EgUnNPCgR74+GtdTb9i 41TKMkzAtPygJrcBkE1NHZ/YFqpzZDnloslSmk8b5D4rg+QIhhl7+OTmqbJhpePn43kXZJD/Df ZXu/D5LMoV1uSSvR4/6rgb8QzPYzWuH6EBqp3j5nPnL78HISScVbbxCReZShvJw5dcMeyFnJCg T2q/exNLTeAvT1W70LY6x0UQGgEVVjAxo30JlGtCBAw8qA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=5W+v0Ml7AvCAibD3FS9HU5Ec3L0WJQQ56UOTJxkL7DU=; b=aNC7QhVOCfD0TNNZlBlW5xapvM EMu2r5dSEWfibaxD67x/kOZLvuMre4LodPJYqoF0YcgRKAHmxp9OnNl2cED538r+kTjBfb2t5whSv 5FO1h9heoOwwD85Qs5KYR1bSi+7DsXFj05CUgf50um2xTA0S3nyfQfCNn6FlgMpdSGjIambilWipB sVeZtukXQ9SnwYkhX1qvvTpK9kD8Ug8mgkJM7SBM/OdWsZt08wuG65kqOiDRcgspvhmbUgxZq/kGx arrbvxP7ROSpfW3jzNfm4KFfe3ncqE0Ei4MnVILL+2cFizjvV5kszrYA8xMy0YphoqDh9qAyk7H1o nT/LXx7A==; Received: by zero.zsh.org with local id 1rKiCd-000C4y-E2; Tue, 02 Jan 2024 17:05:19 +0000 Authentication-Results: zsh.org; iprev=pass (csmtpq4-prd-nl1-vmo.edge.unified.services) smtp.remote-ip=84.116.50.41; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from csmtpq4-prd-nl1-vmo.edge.unified.services ([84.116.50.41]:64959) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1rKiCO-000Blm-GN; Tue, 02 Jan 2024 17:05:05 +0000 Received: from oxsmtp4-prd-nl1-vmo.nl1.unified.services ([100.107.83.44]) by csmtpq4-prd-nl1-vmo.edge.unified.services with esmtp (Exim 4.93) (envelope-from ) id 1rKiCM-003sIi-Dc for zsh-workers@zsh.org; Tue, 02 Jan 2024 18:05:02 +0100 Received: from oxbe25-prd-nl1-vmo.nl1.unified.services ([100.107.83.71]) by oxsmtp4-prd-nl1-vmo.nl1.unified.services with ESMTP id KiCMrO9j32RyUKiCMraGlP; Tue, 02 Jan 2024 18:05:02 +0100 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 100.107.83.71 X-CNFS-Analysis: v=2.4 cv=IpgYcq/g c=1 sm=1 tr=0 ts=6594423e cx=a_exe a=iCgrz56N8FNiO+T+6uuiSQ==:117 a=IvlwODmuRu4A:10 a=IkcTkHD0fZMA:10 a=q34bkTyjAAAA:8 a=3RMS29UHZJD6L4qriu8A:9 a=QEXdDO2ut3YA:10 a=HbQOABYz3jhqdZF7JfnK:22 a=c10cvU6awwLw48PoI_dg:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1704215102; bh=bkVjZJPzUGjofMw5L7gehn6xQ6NA0GFZ0nj2xIRqeOs=; h=Date:From:To:In-Reply-To:References:Subject; b=S/ipT9Cx9cBNRu0kfvWYCHiLPctQHpHGUbC5y+DeGE2n59Ky30/EhRwsyRSptyO8j DGviELP3ngKXHlzsprZ2wxlh/M0RVVNPlFnvyRjQB/xI4bNUEMZ/NCRPQkPAiCxYmR wVugmYTnwheRnkOzPSTdRnS0Vg3OCKQDaGvQu8ojjiDQILIjwXFNo8sBGvJnvTgC5R 9SxFsOFBdAkWNDafsfAVMzS1O72AHqZp4qvkTDyjuyhFQFUKiun5FBJuIGuDckw1mS Y6gpTC4YOioDbz08j7A46W/lpK8DEnma/kO5JUvJpCfMdzGeTyjr06QiOVmdnbg7ue dm4BFS9qhBC7g== Date: Tue, 2 Jan 2024 17:05:02 +0000 (GMT) From: Peter Stephenson To: zsh-workers@zsh.org Message-ID: <817638116.1728541.1704215102364@mail.virginmedia.com> In-Reply-To: References: Subject: Re: Regression: 'read -s' does not disable echo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer X-Originating-IP: 147.161.224.196 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfOMMYjEyIlseeh8/fhIuG9VJ6L4yZV2+zV5E5CHvqBKyx4fsih+p9giLbBs4tkeEBbGdiHEGS4lIvj0sQsMT5Vw1XuW9osE0BfMPWswGzggzkx+WGwR+ gKNbmc5oJLD+3Kdb4zWg2NUs4Aec6+ek95wXtOVuFQruazvB6ULWTHh2he0FVeZIUA1xKGK5kYGd6NNW6MlAqnWRE86UWYwQsWHxnvBAWTOlh/Nfd/01VVmj X-Seq: 52459 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > On 02/01/2024 15:25 GMT Phil Pennock wrote: > > > Folks, there's a regression on git mainline such that `read -s` does not > suppress terminal echo. That's not very friendly. I guess it's to do with the way readfd is handled. Something like this, or more general? Simpler is probably better here. pws diff --git a/Src/builtin.c b/Src/builtin.c index 9e08a1dbc..dc651f687 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -6506,7 +6506,8 @@ bin_read(char *name, char **args, Options ops, UNUSED(int func)) } else readfd = izle = 0; - if (OPT_ISSET(ops,'s') && SHTTY == readfd) { + if (OPT_ISSET(ops,'s') && + (SHTTY == readfd || (readfd == 0 && isatty(0)))) { struct ttyinfo ti; memset(&ti, 0, sizeof(struct ttyinfo)); gettyinfo(&ti);