From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-32958-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 8085 invoked by alias); 4 Aug 2014 19:52:12 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 32958
Received: (qmail 27878 invoked from network); 4 Aug 2014 19:51:59 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,RCVD_IN_DNSWL_MED autolearn=ham
	version=3.3.2
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com s74JSXwV024993
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=isilon.com; s=jan2013;
	t=1407180515; bh=lOgu0IOXxdHqr9ItCU/Wd+163pM=;
	h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version;
	b=Td+h6I1dt/mQelGRcI+27zi3WNHSl5Kj2vhevzEJaS1KpK2iiZrLH3n6jk9RF0nwT
	 Vw72llYTtLffo+0xhMGcvIdcR7gTNG9wdILcj9FcdMXQWtLG3bjoXgsOOzO9gbljQ5
	 i2oq21AJeGuqtx5+T/oniOn+yOXaPCwabIQsRWog=
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com s74JSXwV024993
From: Miles Ohlrich <miles.ohlrich@isilon.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: suggested patch for error flagged in static analysis
Thread-Topic: suggested patch for error flagged in static analysis
Thread-Index: Ac+wGjtoKaVfCG4bRNWABIkHQDJ9Xw==
Date: Mon, 4 Aug 2014 19:28:13 +0000
Message-ID: <83960560B9A9E445909AC748DB1139982B5AB441@MX103CL01.corp.emc.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.7.177.112]
Content-Type: multipart/alternative;
	boundary="_000_83960560B9A9E445909AC748DB1139982B5AB441MX103CL01corpem_"
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd53.lss.emc.com
X-RSA-Classifications: public

--_000_83960560B9A9E445909AC748DB1139982B5AB441MX103CL01corpem_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

I see this flagged as a "logical vs. bitwise operation" in my static analys=
is tool.

!CMF_FILE is always 0.  Should be ~CMF_FILE.

--- zsh-5.0.5/Src/Zle/compctl.c.orig    2014-08-04 12:20:54.327001219 -0700
+++ zsh-5.0.5/Src/Zle/compctl.c    2014-08-04 12:21:41.079945543 -0700
@@ -3389,11 +3389,11 @@ makecomplistflags(Compctl cc, char *s, i
         if (nonempty(l)) {
             /* And add the resulting words. */
             mflags |=3D CMF_FILE;
             for (n =3D firstnode(l); n; incnode(n))
             addmatch(getdata(n), NULL);
-            mflags &=3D !CMF_FILE;
+            mflags &=3D ~CMF_FILE;
         }
         opts[NULLGLOB] =3D ng;
         } else {
         char **dirs =3D 0, *ta[2];



--_000_83960560B9A9E445909AC748DB1139982B5AB441MX103CL01corpem_--