From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20062 invoked by alias); 6 Nov 2014 23:55:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33624 Received: (qmail 1164 invoked from network); 6 Nov 2014 23:55:31 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1415317705; bh=vMIL56Z3iaMBu0BnrL6VjxxHjytL/mJV+SphtRex/R4=; h=From:To:Subject:Date:From:Subject; b=Ry5O7MT9O/8qc+dEjYfsC16xZ+EsM1xxH11Ju3zUb9i0vBC+UBcDt5G8kryVKmqe31RfRgHgwnT/MHYfzl8pxtojNbsIvGsRj2jeDqFM1g7MU+z/41v3koDiqUEiH1iDP2vwiyDIfGplNVVhDb20TGPOhsrib98SKmXsYVbIz/SQNP2Er/OnfjZre/uE9NGg1LFnFJ0dACkW7933ZhXbwTzKgnLAMXRm1L12KtD894Zh/ivx6w3dNGcrGGKad8EygbvUMKH8UVzDXcMftTY7te3WNPN/GvDeM9LCAT9SJpd2hlXxtsDjQAoF3vOYKBF686Dgls4KV2M7jKlHKHKAng== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.co.uk; b=prgbg+o9C1ABCJpybrU0UDY1JWQeWUmlRefFpEspiesV536bYPo1Ma3LsmSmRqM461JrYoeJaW23DCNHALhSre6+J2WaXAjRwPsR//Yu9oszx36FU4L7k0KGGfzcZv42cx4DnchcD5/Zf2Ctst7PasRfIBSbb6+egyRE4tHy3RunPHwtrQGOqS9bnT5Qij2HvGFEoQuxZUYGSISPQhTmT9DZoFqnhNyJxXlpLN+btDipqQKwmToawLESj6092h9pcuo5ytcBwmA7fbLTZHjShBaf7wMneKPMX7cSeTH4MDUBYp8Fq/MXtVT9V1CXAokcuWewv/y3AmfmQGXb4WD/xA==; X-Yahoo-Newman-Id: 44893.61631.bm@smtp128.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: gce6zywVM1ntVuqHpcjskh.c9hoUgNkIlZm2zRxIl.62DNb hlVWBzyxnXe744cTIQ3ZL52s38OsSw6.N8RQfMW3nPSqQaK0_cB9.4N9TJfc t6Y0ljx.gZxck_o_bKpt4ypKqVmi2WLsf88H_fI0vCR.2UOhoeuJgsAD4PhJ cbtM5HR7UPghqJaCPK2kH0UPByPTqqNkFathlQfqDPbWmBXxnjplCu8mv690 nEs41yaPyiM_lkqUPRtm3W2Y1w.Vk5cv_VMD2HjQlBORbq09K39gAFQwwCq. _FRo0498tMuFs4iQecpsjUA9JIUvngANjLhnfdDtH.HCsfS1b74vTgGb9b6W I5BpzP7srYYaHIRWIKusB7vQhpqjhLtf8YGCN.MLsL8wItdtMU0Y.qB1Ktoi VR7QIIb.KF3DP720FS2RrzEnaHbwRUsVav8G3ubab_Nvv4oknliP1fBcT4nJ rjae2RHSerfQ0MaM6w4mUaUcyGZeJOnvS6jgD0w8J38k.UlLdVdI5Ebulqzo AfiIpU2DYS2jVQAEa2fYYk_1fH1E- X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- From: Oliver Kiddle To: Zsh workers Subject: PATCH: keep region active when widget fails MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8412.1415317701.1@thecus.kiddle.eu> Date: Fri, 07 Nov 2014 00:48:23 +0100 Message-ID: <8414.1415317703@thecus.kiddle.eu> Does anyone know why we set region_active to false in handlefeep()? I would guess that there are perhaps cases where we want this but things like cursor left when you're already in the first position shouldn't unset region_active. Any objections to the following patch? We can always add the assignment to individual widgets if we find cases where it is desirable. Oliver diff --git a/Src/Zle/zle_utils.c b/Src/Zle/zle_utils.c index e95a34b..03a2bdc 100644 --- a/Src/Zle/zle_utils.c +++ b/Src/Zle/zle_utils.c @@ -1365,7 +1365,6 @@ int handlefeep(UNUSED(char **args)) { zbeep(); - region_active = 0; return 0; }