From: "Lawrence Velázquez" <vq@larryv.me>
To: Devin Hussey <husseydevin@gmail.com>
Cc: Bart Schaefer <schaefer@brasslantern.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] Allow globbing with unreadable parent directories
Date: Wed, 13 Jan 2021 20:32:58 -0500 [thread overview]
Message-ID: <8563F702-5AC3-42C7-9FF9-B736A11B1A0D@larryv.me> (raw)
In-Reply-To: <CAEtFKssJVz9mr3vA_vY77m2bsrXWBKHz1qgv83jzeY0jLXzPjQ@mail.gmail.com>
> On Jan 13, 2021, at 7:27 PM, Devin Hussey <husseydevin@gmail.com> wrote:
>
>> On Wed, Jan 13, 2021, 5:28 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>>
>> As far as I can tell, the patch
>> would only cause globbing to fail in more cases, not succeed where it
>> previously did not.
>
> No, that is definitely not the case.
But your patch *does* cause globbing to fail in cases for which it
currently doesn't.
% mkdir -p notsearchable/{dir,DIR}
% touch notsearchable/{dir,DIR}/file
% chmod 600 notsearchable
% zsh -fc 'echo notsearchable/*'
notsearchable/DIR notsearchable/dir
% ./zsh-patched -fc 'echo notsearchable/*'
zsh:1: no matches found: notsearchable/*
> opendir() would fail if either R_OK or X_OK was false, causing unreadable folders to be a false negative.
>
> This is allowing certain combinations where opendir() would fail.
If I'm understanding your intention correctly, you would like
"literal" segments (e.g., lacking special characters) of
case-insensitive glob patterns to match literally if the "parent"
lacks read permissions. This doesn't seem to work, though. Am I
missing something?
% mkdir -p notreadable/dir
% touch notreadable/dir/file
% chmod 300 notreadable
% zsh -f +o CASE_GLOB -c 'echo notreadable/dir/*'
zsh:1: no matches found: notreadable/dir/*
% ./zsh-patched -f +o CASE_GLOB -c 'echo notreadable/dir/*'
zsh:1: no matches found: notreadable/dir/*
vq
next prev parent reply other threads:[~2021-01-14 1:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 3:04 Devin Hussey
2021-01-13 22:27 ` Bart Schaefer
2021-01-14 0:27 ` Devin Hussey
2021-01-14 1:32 ` Lawrence Velázquez [this message]
2021-01-14 2:22 ` Devin Hussey
2021-01-14 2:24 ` Devin Hussey
2021-01-17 17:22 ` Daniel Shahaf
2021-01-17 18:02 ` Bart Schaefer
2021-01-17 18:23 ` Bart Schaefer
2021-01-14 4:04 ` Bart Schaefer
2021-01-14 5:57 ` NO_CASE_GLOB and unreadable directories (Episode VI: A New Hope) Bart Schaefer
2021-01-14 18:56 ` Bart Schaefer
2021-01-25 0:52 ` Bart Schaefer
2021-01-25 14:05 ` Peter Stephenson
2021-02-05 5:53 ` Bart Schaefer
2021-02-06 12:31 ` Daniel Shahaf
2021-03-27 17:31 ` Lawrence Velázquez
2021-04-10 20:56 ` Lawrence Velázquez
2021-04-10 21:22 ` Bart Schaefer
2021-04-13 11:46 ` Daniel Shahaf
2021-04-13 21:33 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8563F702-5AC3-42C7-9FF9-B736A11B1A0D@larryv.me \
--to=vq@larryv.me \
--cc=husseydevin@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).