From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Felipe Contreras" <felipe.contreras@gmail.com>, zsh-workers@zsh.org
Subject: Re: [PATCH 1/3] src: fix build warnings
Date: Sat, 02 Jan 2021 11:22:11 +0000 [thread overview]
Message-ID: <8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com> (raw)
In-Reply-To: <20201231054131.682544-2-felipe.contreras@gmail.com>
Felipe Contreras wrote on Thu, 31 Dec 2020 05:41 +00:00:
> utils.c: In function ‘getkeystring’:
> cc1: warning: function may return address of local variable [-Wreturn-local-addr]
> utils.c:6703:16: note: declared here
> 6703 | char *buf, tmp[1];
> | ^~~
>
> diff --git a/Src/utils.c b/Src/utils.c
> index 5151b89a8..37ae4c854 100644
> --- a/Src/utils.c
> +++ b/Src/utils.c
> @@ -6700,7 +6700,8 @@ ucs4toutf8(char *dest, unsigned int wval)
> mod_export char *
> getkeystring(char *s, int *len, int how, int *misc)
> {
> - char *buf, tmp[1];
> + static char tmp[1];
> + char *buf;
The docstring explicitly promises the returned string will be newly-
allocated from the heap, so this change makes the implementation
inconsistent with the docstring.
No comment on the pattern.c part.
next prev parent reply other threads:[~2021-01-02 11:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 5:41 [PATCH 0/3] Build fixes Felipe Contreras
2020-12-31 5:41 ` [PATCH 1/3] src: fix build warnings Felipe Contreras
2021-01-02 11:22 ` Daniel Shahaf [this message]
2021-01-02 16:41 ` Mikael Magnusson
2021-01-02 18:30 ` Felipe Contreras
2021-01-04 5:14 ` Daniel Shahaf
2021-03-27 19:28 ` Lawrence Velázquez
2021-04-04 6:38 ` Jun. T
2020-12-31 5:41 ` [PATCH 2/3] autoconf: remove deprecated functions Felipe Contreras
2021-03-27 19:37 ` Lawrence Velázquez
2021-04-03 15:04 ` Lawrence Velázquez
2020-12-31 5:41 ` [PATCH 3/3] autoconf: prepare for 2.70 Felipe Contreras
2021-03-27 19:38 ` Lawrence Velázquez
2021-04-03 15:44 ` Lawrence Velázquez
2021-04-08 22:44 ` Oliver Kiddle
2021-04-09 4:18 ` Jun T
2021-04-09 20:08 ` Oliver Kiddle
2021-04-09 20:28 ` Peter Stephenson
2021-04-09 23:04 ` Bart Schaefer
2021-04-09 23:19 ` Mikael Magnusson
2021-04-10 0:37 ` Jun. T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=felipe.contreras@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).