From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24843 invoked from network); 2 Jan 2021 11:22:55 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 2 Jan 2021 11:22:55 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1609586575; b=FN5vhhDPZo/M1O+ewgjX6PuFcUa9a8YMg8lnh0qHcPz+dPl8E38jfHqmGPx0Dwb0ilZ56IE0c4 NP5lLFPC5pOrCpipMKBahj2PP6dCO5mopIeaoCAXEQBMY0F1/Wx/DSmkbgJUZywonth6AODB2F Eo2Iux3cpVUn8ctMgd6M+ButUQVPRQmqoVVk5ZGGXM6F9beIOUDu06N9E6dLRlgLPu16EzoCx2 XaY5mKEI/tUS2yS68DqHTKB7CurtnGAeX6VwePP1+vPjPdaI2EtLm1qDkNRv2d/XbDpICiatrw FnzNCxXlnEj7j9VdLpg5qQxQG1UxWnqarafgOzjTmIPU9g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1609586575; bh=TEg72wvJpFuJSehN4K8WnslJa+R504301QpbRrFz0jg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Subject:To:From:Date: References:In-Reply-To:Message-ID:MIME-Version:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=I5e9T8aLXNOIznnOCzOi+qPnVfdOwANW/O8T9sUfWqg76fuocw9Uf0JBRauCJuiHPmv4IMBniK rRb25HUd8Qj8VcDq5xQjX8bauzfKCBFLwnXl7GgFDucYQ3m1b8uerTJxD2LHdR8dR1WGGEE1Yq abvISrSe6JHg96CIMmzD2UXm+HC2YisQRMWWcAZNiSQol5DVW7P7sGObO1iWbCQOegkhFSQ7G8 glC6lQSUgP18CArlWO2ngLfgFg8r7ZxuR/drMWbgBoPuedGzsIjGa4BUmkk1jTMZX42hsAzgo3 m5ay5F+SbaGArvR6bBH/uQIH+gDO4QpWxaBVFUOPMjbrkQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Subject:To:From:Date:References:In-Reply-To:Message-Id: Mime-Version:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=85fOYWyeAqaCe5qvynVC1syXJjaJr6BFAXMh5gJnb2o=; b=CrAW204yW8M9siVKBFgNRPg4TW 39BeIc5iX7WlZ3h3VA2FuRuCMprBAkwRxK3Sm2QJ7GruIeRSurT677hKJmqC4o7XDjvaC+jCkiQH8 DuoqNYT7OXZQZxj8v1F2r8gmbqR73P2CyuhzML4spPYFNZ6rNHkCwClklB9j/MYy/lXuxtC1a3UbA 38lNOY631euAeCq54PIYDGFw/jFZiQV/syi7ho9HMBqL27+O47TFBT5nTRWYEuEtlOGUvTrfaov76 bv08eylFMdRdH9u8bn/IE0znuQqJ+39+nB7Wxom4RZFNfU7ULvOxdmNDiiwYRNGOOrPn/Pwgsi80v 7cEdtYgA==; Received: from authenticated user by zero.zsh.org with local id 1kvezk-0001kO-CV; Sat, 02 Jan 2021 11:22:52 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45337) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1kvezR-0001cV-Sc; Sat, 02 Jan 2021 11:22:36 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0126B5C0244; Sat, 2 Jan 2021 06:22:32 -0500 (EST) Received: from imap37 ([10.202.2.87]) by compute3.internal (MEProxy); Sat, 02 Jan 2021 06:22:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:subject:content-type :content-transfer-encoding; s=fm2; bh=85fOYWyeAqaCe5qvynVC1syXJj aJr6BFAXMh5gJnb2o=; b=g5qkU3/SNwCYycCMOIICcT1XKF+ZkwYIghNMhnT0wd Spa2M+TdSTIHXdQUrb70NX4sdu+BR5lhadya+YXEsQ3tmis27hzet3KMg0QuPkNj JnmSwRHtKW70FG5cA689/bkPASmR4ALTxkClRLO6VDA4KzN9fzx6ucfH7UU1HyKF 1TiZgcTzsq2oeapFf1iWn5WXdt/aJj9pVt2znbIrPGnoCfMav0f1JKhJLuLPBHCR 6xtJq4fN0hqt5FYUS8UOCJPuVKEAuoOd+c3Bd39/VF6FkiDH10MkSH0RbZYBff7+ BONRkGb+B1140xX/KHLC3jwta7UV/wIwiMms1MWrwwfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=85fOYWyeAqaCe5qvynVC1syXJjaJr6BFAXMh5gJnb 2o=; b=C3ATjL31VAdX7/0JUOMCEsgEhf1fMGh5yqFdJ7h7kO1Bc+RGl+TIZX9b/ 56ZWNkziInfo7buJUwV+d2juNbGdIh1O1hjh3j5ojmHNJmtahSeXNxdaTk8Fjcy4 dmvYjAWSy2vJ47+y45T1+R6vUmhvcTmYyzgmvMlfeEGhJ2tbO6SqDX4wo8Ii4ePT LiDscf+BSsdKvxSMs4J72ehPwpznhG3PWtqsU8bV7wXciCaSQTQrSL4fY2S5+t7e XsCCpSCDgSRcx3kFLZJ4WnjdWK+nxB5pDrZgeYx08jTflu01+kYF32pPzfekCC2g Q+aQ2/iouJXfmmWHkL7vd19PMq/cg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvddvledgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedfffgr nhhivghlucfuhhgrhhgrfhdfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmh gvqeenucggtffrrghtthgvrhhnpeefhfekfeevieelleehiefftdekudejledvhfdtjedt geegvdeuffefleehhfdvgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1209B1900078; Sat, 2 Jan 2021 06:22:32 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.1-61-gb52c239-fm-20201210.001-gb52c2396 Mime-Version: 1.0 Message-Id: <8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com> In-Reply-To: <20201231054131.682544-2-felipe.contreras@gmail.com> References: <20201231054131.682544-1-felipe.contreras@gmail.com> <20201231054131.682544-2-felipe.contreras@gmail.com> Date: Sat, 02 Jan 2021 11:22:11 +0000 From: "Daniel Shahaf" To: "Felipe Contreras" , zsh-workers@zsh.org Subject: Re: [PATCH 1/3] src: fix build warnings Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Seq: 47787 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Felipe Contreras wrote on Thu, 31 Dec 2020 05:41 +00:00: > utils.c: In function =E2=80=98getkeystring=E2=80=99: > cc1: warning: function may return address of local variable [-Wretur= n-local-addr] > utils.c:6703:16: note: declared here > 6703 | char *buf, tmp[1]; > | ^~~ >=20 > diff --git a/Src/utils.c b/Src/utils.c > index 5151b89a8..37ae4c854 100644 > --- a/Src/utils.c > +++ b/Src/utils.c > @@ -6700,7 +6700,8 @@ ucs4toutf8(char *dest, unsigned int wval) > mod_export char * > getkeystring(char *s, int *len, int how, int *misc) > { > - char *buf, tmp[1]; > + static char tmp[1]; > + char *buf; The docstring explicitly promises the returned string will be newly- allocated from the heap, so this change makes the implementation inconsistent with the docstring. No comment on the pattern.c part.