zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] new completion for otool command (macOS)
Date: Thu, 4 Jan 2018 11:27:06 -0600	[thread overview]
Message-ID: <865007B4-E944-4090-9072-F60DBD4634D3@dana.is> (raw)
In-Reply-To: <A37CD241-FB6D-4BAE-9728-313F7BC46827@kba.biglobe.ne.jp>

On 3 Jan 2018, at 21:31, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>If there is a possibility that .dylib does not have an execution permission,
>then please add it to _object_files.

I don't have much experience with the other extensions you mentioned (except
.bundle is a directory i thought). But i did look at the .dylib files on my
machine, and it seems pretty well split on whether they'll be executable. Most
of the ones Apple ship in /usr/lib are, but over half of the ones i've got from
Homebrew are not. So i suppose it's worth adding it.

dana


diff --git a/Completion/Unix/Type/_object_files b/Completion/Unix/Type/_object_files
index 70b5b6688..595265116 100644
--- a/Completion/Unix/Type/_object_files
+++ b/Completion/Unix/Type/_object_files
@@ -5,7 +5,7 @@ local expl
 _description files expl 'object file'
 
 __object_file() {
-  [[ -x $REPLY || $REPLY = *.(a|o|elf) || $REPLY = *.so(.<->)# ||
+  [[ -x $REPLY || $REPLY = *.(a|o|elf|dylib) || $REPLY = *.so(.<->)# ||
 	$REPLY = (core*|*.core) ]]
 }
 


      reply	other threads:[~2018-01-04 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-31  2:57 Jun T.
2017-12-31  3:38 ` dana
2018-01-04  3:31   ` Jun T
2018-01-04 17:27     ` dana [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865007B4-E944-4090-9072-F60DBD4634D3@dana.is \
    --to=dana@dana.is \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).